SFML community forums

General => General discussions => Topic started by: FRex on February 09, 2014, 05:38:00 pm

Title: Complying with zlib license
Post by: FRex on February 09, 2014, 05:38:00 pm
This is mainly a Laurent question, since it's his property after all. :P
If I take code from SFML (but not copy verbatim a file, just a single method from somewhere) is it enough to put notice like that just above the method in .cpp file
//code below was taken from SFML Text.cpp and MODIFIED,
//it is NOT the original software, if looking for original software see:
//https://github.com/SFML/SFML/
followed by exact copy of zlib text that appeared in the file I took a method from?

So it goes like:
1. my code in my .cpp
2. that notice
3. SFML original (c) text
4. SFML code (modified or not)
5. end of file

I'd say I'm fulfilling all three: I don't misrepresent the origin, I plainly mark the (changed) copy as not the original and I don't remove or modify the original notice. (I feel a bit fishy about the last.)
Zlib lib/license FAQ doesn't really help, it talks more about what steps to take when releasing own fork of entire library. http://www.zlib.net/zlib_faq.html#faq24
Title: Re: Complying with zlib license
Post by: eXpl0it3r on February 09, 2014, 06:07:30 pm
I'm not an expert here, but my understanding of "software" as used in the license, means the whole package or maybe a full module. So if you clone SFML and add a few modifications to it, then you'll have to clearly mark the original author and that it's a modified version.
However if you just copy a function, then I don't think these rules apply, given that one function doesn't necessarily make up a full "software". At which point code turns into software is probably something lawyers would discuss.

My understanding of the zlib license is, that it protects the full source code from being ripped off and sold as someone else's code and it protects the author from being hold liable for things connected to SFML. But since I'm not a lawyer, don't believe anything. :D
Title: Re: Complying with zlib license
Post by: Laurent on February 09, 2014, 06:14:26 pm
It looks ok to me.
Title: Re: Complying with zlib license
Post by: Tank on February 10, 2014, 08:57:34 am
Quote
Zlib lib/license FAQ doesn't really help, it talks more about what steps to take when releasing own fork of entire library.
Technically it shouldn't be a difference. In your case you've forked SFML, removed everything but one function, and then added your stuff. ;)