SFML community forums

Help => Graphics => Topic started by: HavingPhun on June 15, 2014, 10:31:45 pm

Title: Custom button class does not display. [SOLVED]
Post by: HavingPhun on June 15, 2014, 10:31:45 pm

Hello, I have been teaching myself how to use SFML 2.1 for a few days and am having trouble getting a button object I made draw itself to a window. My program runs without any errors.

Main.cpp:

(click to show/hide)

#include "Files.h"
#include "EntityManager.h"
#include "Tile.h"
#include "Degree.h"
#include "Entity.h"
#include "Button.h"

int main()
{
    sf::Font GameFont;
    GameFont.loadFromFile("C:/Users/Luke/Desktop/Projects/Project2/Arial.ttf");
    sf::Text GameText("Text", GameFont);
    GameText.setCharacterSize(25);
    GameText.setStyle(sf::Text::Regular);
    GameText.setColor(sf::Color::White);

    sf::RenderWindow MainWindow;
    enum State{STARTING, MAINMENU, LOADING, INGAME, EXITING};

    sf::Vector2i IPosition;
    sf::Vector2f MPosition;

    std::string InputText;

    Button TestButton;
    TestButton.InitializeButton("C:/Users/Luke/Desktop/Projects/Project2/Arial.ttf", 30, sf::Text::Regular, sf::Color::White, "Test Button", sf::Color::Blue);
    TestButton.SetButtonOrigin(200.0f, 400.0f);
    MainWindow.create(sf::VideoMode(800, 600), "Project 2");

    while(MainWindow.isOpen())
    {
        sf::Event GameEvent;
        while(MainWindow.pollEvent(GameEvent))
            {
                MainWindow.clear();
                switch(GameEvent.type)
                {
                    case sf::Event::Closed:
                        MainWindow.close();
                        break;

                    case sf::Event::MouseMoved:
                        break;

                    default:
                        break;
                }
            MainWindow.draw(TestButton);
            MainWindow.display();
            }

    }

    return 0;
}

 

Button.h:

(click to show/hide)

#ifndef BUTTON_H
#define BUTTON_H
#include "Files.h"

class Button : public sf::Drawable
{
    public:
        Button();
        ~Button();

        void InitializeButton(std::string FontAddress, int FontSize, sf::Text::Style FontStyle, sf::Color FontColor, std::string ButtonString, sf::Color ButtonColor);

        sf::RectangleShape ButtonRectangle;
        sf::Font ButtonFont;
        sf::Text ButtonText;

        sf::Vector2f ButtonScale;
        sf::Vector2f ButtonOrigin;

        //void DefineButtonSprite(sf::Sprite& BSprite , sf::Texture& BTexture); //Currently Unused.
        void UpdateTextScale(int TextSize, std::string TextString);
        void SetButtonOrigin(float OriginX, float OriginY);
        virtual void draw(sf::RenderTarget& target, sf::RenderStates states) const;

    protected:

};

#endif // BUTTON_H

 

Button.cpp:

(click to show/hide)

#include "Button.h"

Button::Button()
{

}

Button::~Button()
{
    //dtor
}

void Button::InitializeButton(std::string FontAddress, int FontSize, sf::Text::Style FontStyle, sf::Color FontColor, std::string ButtonString, sf::Color ButtonColor)
    {
        ButtonFont.loadFromFile(FontAddress);
        UpdateTextScale(FontSize, ButtonString);
        ButtonText.setStyle(FontStyle);
        ButtonText.setColor(FontColor);
        ButtonRectangle.setFillColor(ButtonColor);
    }

void Button::UpdateTextScale(int TextSize, std::string TextString)
    {
        ButtonText.setCharacterSize(TextSize);
        ButtonText.setString(TextString);
        ButtonScale = ButtonText.getScale();
        ButtonRectangle.setScale(ButtonScale);
    }

void Button::SetButtonOrigin(float OriginX, float OriginY)
    {
        ButtonOrigin.x = OriginX;
        ButtonOrigin.y = OriginY;
        ButtonText.setOrigin(ButtonOrigin);
        ButtonRectangle.setOrigin(ButtonOrigin);
    }

void Button::draw(sf::RenderTarget& target, sf::RenderStates states) const
    {
        target.draw(ButtonRectangle, states);
        target.draw(ButtonText, states);
        std::cout << "\n Button::draw()";
    }

 

Files.h:

(click to show/hide)

#ifndef FILES_H_INCLUDED
#define FILES_H_INCLUDED

#include <vector>
#include <map>
#include <string>
#include <iostream>
#include <cmath>
#include "SFML/Graphics.hpp"
#include "SFML/Window.hpp"
#include "SFML/System.hpp"

#endif // FILES_H_INCLUDED

 

I made button inherit sf::drawable and made sure I did it in the same way that sf::sprite did so I could draw buttons in the same way you can draw sprites by calling window.draw(sprite). Though there are no errors when compiling and running the program, neither the buttons rectangle or it's text are drawn. I cannot figure out why though.

Thank you ahead of time for any help, and any other general tips or criticism of my code is welcome, especially if I am doing something horribly wrong.

OS: Windows 7 64bit.
SFML Version: 2.1 Static.
GPU: EVGA gtx 670 ftw.

Title: Re: Custom button class does not display.
Post by: Ixrec on June 15, 2014, 10:44:39 pm

For the rectangle: I don't see you setting the size anywhere, and the documentation says its default constructor uses a size of (0,0), so I'd try giving it a nonzero size.

For the text: You aren't checking the return value of loadFromFile(), so maybe it just can't find the font file.  If that isn't the issue, could you try drawing a simple sf::Text object (unrelated to your Button class) and make sure that shows up properly?

For style:
- Why give the Button all of its arguments in an initialization method rather than the constructor?
- In general, passing that many arguments in one function is not a good sign.  One alternative that might be more readable would be having the constructor take a size and position, then using setFont(), setColors() and setString() methods to neatly split up all the other parameters.
- MainWindow.clear(); should be underneath the event loop, next to draw() and display().  I actually didn't see it for a while, and nearly wrote a post explaining why you need to call clear().
- Your indentation is inconsistent in a few places.
- //dtor is a completely superfluous comment

Title: Re: Custom button class does not display.
Post by: HavingPhun on June 15, 2014, 11:34:29 pm

Quote from: Ixrec on June 15, 2014, 10:44:39 pm

For the rectangle: I don't see you setting the size anywhere, and the documentation says its default constructor uses a size of (0,0), so I'd try giving it a nonzero size.

For the text: You aren't checking the return value of loadFromFile(), so maybe it just can't find the font file.  If that isn't the issue, could you try drawing a simple sf::Text object (unrelated to your Button class) and make sure that shows up properly?

Thank you for the quick response, I have made the changes you suggested in my code. The button still does not display.

Main.cpp:

(click to show/hide)

#include "Files.h"
#include "EntityManager.h"
#include "Tile.h"
#include "Degree.h"
#include "Entity.h"
#include "Button.h"

int main()
{
    sf::Font GameFont;
    GameFont.loadFromFile("C:/Users/Luke/Desktop/Projects/Project2/Arial.ttf");
    sf::Text GameText("Text", GameFont);
    GameText.setCharacterSize(25);
    GameText.setStyle(sf::Text::Regular);
    GameText.setColor(sf::Color::White);

    sf::RenderWindow MainWindow;
    enum State{STARTING, MAINMENU, LOADING, INGAME, EXITING};

    sf::Vector2i IPosition;
    sf::Vector2f MPosition;

    std::string InputText;

    Button TestButton("C:/Users/Luke/Desktop/Projects/Project2/Arial.ttf", 30, "Test Button");
    TestButton.SetButtonTextStyle(sf::Text::Style::Regular);
    TestButton.SetButtonTextColor(sf::Color::White);
    TestButton.SetButtonRectangleFillColor(sf::Color::Blue);

    TestButton.SetButtonOrigin(200.0f, 400.0f);
    MainWindow.create(sf::VideoMode(800, 600), "Project 2");

    while(MainWindow.isOpen())
    {
        sf::Event GameEvent;
        while(MainWindow.pollEvent(GameEvent))
            {
                switch(GameEvent.type)
                {
                    case sf::Event::Closed:
                        MainWindow.close();
                        break;

                    case sf::Event::MouseMoved:
                        break;

                    default:
                        break;
                }
            MainWindow.draw(GameText);
            MainWindow.draw(TestButton);
            MainWindow.display();
            MainWindow.clear();
            }

    }

    return 0;
}

 

GameText, a separate text from the button class, draws to the screen without any issues.

Button.h:

(click to show/hide)

#ifndef BUTTON_H
#define BUTTON_H
#include "Files.h"

class Button : public sf::Drawable
{
    public:
        Button();
        Button(std::string FontAddress, int FontSize, std::string ButtonString);
        ~Button();

        sf::RectangleShape ButtonRectangle;
        sf::Font ButtonFont;
        sf::Text ButtonText;

        sf::Vector2f ButtonScale;
        sf::Vector2f ButtonOrigin;

        //void DefineButtonSprite(sf::Sprite& BSprite , sf::Texture& BTexture); //Currently Unused.
        void SetButtonTextStyle(sf::Text::Style TextStyle);
        void SetButtonTextColor(sf::Color TextColor);
        void SetButtonRectangleFillColor(sf::Color RectangleColor);

        void UpdateTextScale(int TextSize, std::string TextString);
        void SetButtonOrigin(float OriginX, float OriginY);
        virtual void draw(sf::RenderTarget& target, sf::RenderStates states) const;

    protected:

};

#endif // BUTTON_H

 

Button.cpp:

(click to show/hide)

#include "Button.h"

Button::Button()
    {

    }

Button::Button(std::string FontAddress, int FontSize, std::string ButtonString)
    {
        sf::Vector2f rect;
        rect.x = 100.0f;
        rect.y = 100.0f;

        ButtonRectangle.setSize(rect);
        ButtonFont.loadFromFile(FontAddress);
        if(ButtonFont.loadFromFile(FontAddress) == 0)
            {
                std::cout << "\nFailed to load.";
            }
        else if(ButtonFont.loadFromFile(FontAddress) == 1)
            {
                std::cout << "\nLoaded Font.";
            }
        UpdateTextScale(FontSize, ButtonString);
    }

Button::~Button()
    {

    }

void Button::SetButtonTextStyle(sf::Text::Style TextStyle)
    {
        ButtonText.setStyle(TextStyle);
    }

void Button::SetButtonTextColor(sf::Color TextColor)
    {
        ButtonText.setColor(TextColor);
    }

void Button::SetButtonRectangleFillColor(sf::Color RectangleColor)
    {
        ButtonRectangle.setFillColor(RectangleColor);
    }

void Button::UpdateTextScale(int TextSize, std::string TextString)
    {
        ButtonText.setCharacterSize(TextSize);
        ButtonText.setString(TextString);
        ButtonScale = ButtonText.getScale();
        ButtonRectangle.setScale(ButtonScale);
    }

void Button::SetButtonOrigin(float OriginX, float OriginY)
    {
        ButtonOrigin.x = OriginX;
        ButtonOrigin.y = OriginY;
        ButtonText.setOrigin(ButtonOrigin);
        ButtonRectangle.setOrigin(ButtonOrigin);
    }

void Button::draw(sf::RenderTarget& target, sf::RenderStates states) const
    {
        target.draw(ButtonRectangle, states);
        target.draw(ButtonText, states);
        std::cout << "\nButton::draw()";
    }
 

At the end of Button::draw I have a cout statement to show if the function runs correctly, my output shows the statement many times so the function is being run. I also set the rectangles initial size to 100 by 100 and it still does not get drawn. I checked the return statement of ButtonFont.loadFromFile and it returns as true. Though I think it already has a check built into itself as I have had it output that the file could not be loaded when I put in the wrong path.

Quote from: Ixrec on June 15, 2014, 10:44:39 pm

For style:
- Why give the Button all of its arguments in an initialization method rather than the constructor?
- In general, passing that many arguments in one function is not a good sign.  One alternative that might be more readable would be having the constructor take a size and position, then using setFont(), setColors() and setString() methods to neatly split up all the other parameters.
- MainWindow.clear(); should be underneath the event loop, next to draw() and display().  I actually didn't see it for a while, and nearly wrote a post explaining why you need to call clear().
- Your indentation is inconsistent in a few places.
- //dtor is a completely superfluous comment

- I moved them to the constructor, that slipped my mind for some reason. I fixed it.
- I have made those changes in the code above.
- Placed it under MainWindow.display().
- When I have Code::Blocks make me a new empty class, it uses different indentation than myself and places //ctor and //dtor in the constructor and destructor. I was too lazy to clean that up, will have to at some point.  ;D

Thank you for your criticism. I will try to look for reasons for why this is still not working, but am stumped so far.

Edit: Added relevant information such as OS, SFML version, and GPU to initial post.

Title: Re: Custom button class does not display.
Post by: Jonki on June 16, 2014, 06:38:31 am

You're not supposed to have your render code inside the event loop. If there are no events, those functions won't be called.

Title: Re: Custom button class does not display.
Post by: HavingPhun on June 16, 2014, 09:41:12 pm

Quote from: Jonki on June 16, 2014, 06:38:31 am

You're not supposed to have your render code inside the event loop. If there are no events, those functions won't be called.

I changed that, It doesn't really make much sense to have my display function in my event loop. I also noticed that I forgot to set ButtonText's font so I this to Buttons constructor.

ButtonText.setFont(ButtonFont);
 

I also changed:

MainWindow.draw(TestButton);
 

To:

MainWindow.draw(TestButton, sf::RenderStates::Default)
 

Since I was not sure if I needed to enter the second argument. Though the button still does not display.

Title: Re: Custom button class does not display. [SOLVED]
Post by: HavingPhun on June 18, 2014, 11:21:04 pm

I fixed it. I set the buttons origin to a position outside of the windows viewing area.

TestButton.SetButtonOrigin(200.0f, 400.0f);
 

This was out of bounds, setting the origin to (0,0) sets it in the upper left corner. Thank you Jonki and Ixrec for your help.