SFML community forums

Help => Graphics => Topic started by: lorence30 on July 05, 2015, 05:42:32 pm

Title: deriving from sf::RenderWindow class
Post by: lorence30 on July 05, 2015, 05:42:32 pm

Im trying to derived from sf::RenderWindow class.
and my question is what are my disadvantages if i do this?

Title: Re: deriving from sf::RenderWindow class
Post by: Hapax on July 05, 2015, 08:10:57 pm

May I ask why?
What changes would you be making and what would the derived class be?

Title: Re: deriving from sf::RenderWindow class
Post by: lorence30 on July 05, 2015, 08:34:13 pm

Just a WindowManager class that has full of static members.
and i dont have any plan on changing the sf::RenderWindow class.

Title: Re: deriving from sf::RenderWindow class
Post by: Hapax on July 05, 2015, 08:51:53 pm

It then may be a better choice to just store a RenderWindow as a member.

There's the whole thing about class inheritance where if you inherit from some other class, then it becomes one. "is a"...
"WindowManager is a RenderWindow" doesn't make sense so inheritance is probably not the right choice here.

Title: Re: deriving from sf::RenderWindow class
Post by: lorence30 on July 06, 2015, 05:25:41 pm

@Hapax
got it! thanks man!

Title: Re: deriving from sf::RenderWindow class
Post by: Nexus on July 06, 2015, 06:57:07 pm

Quote from: lorence30 on July 05, 2015, 05:42:32 pm

Im trying to derived from sf::RenderWindow class.
and my question is what are my disadvantages if i do this?

"Why not" is the wrong question. If you do something, you should have a good reason to do it in the first place, not have no reason against it.

Quote from: lorence30 on July 05, 2015, 08:34:13 pm

Just a WindowManager class that has full of static members.

:o ... and you call that "just"

Don't do that. Both "managers" without clear area of responsibility and "full of static members" are very bad habits. They seem to simplify things, but make everything more complex as soon as you move away from the most basic designs.

Find a good use case for your class, and name it appropriately. Split where necessary.