SFML community forums

Help => General => Topic started by: Ogn1k on May 28, 2024, 09:28:52 am

Title: checking collisions with array of objects takes too much
Post by: Ogn1k on May 28, 2024, 09:28:52 am

Hi everyone. I have this button script:
Button.cpp

(click to show/hide)

#include "Button.h"


Button::Button(float x, float y, float width, float height,
   String text, Texture* image,
   Color idleColor, Color hoverColor, Color activeColor)
{
   ButtonS.setTexture(*image);
   ButtonS.setPosition(x, y);

   texture = *image;

   //ButtonT.setString(text);

   ButtonSetup(x, y, width, height, text, idleColor, hoverColor, activeColor);
}

Button::~Button()
{

}

void Button::setFont(Font* b_font)
{
   ButtonT.setFont(*b_font);
}

void Button::ButtonSetup(float x, float y, float width, float height, String text, Color idleColor, Color hoverColor, Color activeColor)
{
   ButtonState = BTN_IDLE;

   ButtonS.setPosition(x, y);
   ButtonS.setScale(width / ButtonS.getGlobalBounds().width, height / ButtonS.getGlobalBounds().height);

   font->loadFromFile("Resources/Edwardian.ttf");
   ButtonT.setFont(*font);
   ButtonT.setString(text);
   ButtonT.setFillColor(Color::Black);
   ButtonT.setPosition(x, y - 8);
   ButtonT.setCharacterSize(28);

   ButtonBox = RectangleShape(Vector2f(width, height));
   ButtonBox.setPosition(x, y);

   this->activeColor = activeColor;
   this->hoverColor = hoverColor;
   this->idleColor = idleColor;
}

void Button::unPress()
{
   ButtonState = BTN_IDLE;
}

bool Button::isHover()
{
   if (ButtonState == BTN_HOVER)
      return true;
   return false;
}

const bool Button::isPressed() const
{
   if (ButtonState == BTN_ACTIVE)
      return true;
   return false;
}

void Button::ButtonBoxfunc(bool act, Vector2f mousePos, int thick, Color color)
{
   ButtonBoxAct = act;
   if (ButtonBoxAct)
   {
      //std::cout << "asd" << std::endl;
      ButtonBox.setOutlineColor(color);
      ButtonBox.setOutlineThickness(thick);
      ButtonState = BTN_IDLE;
      if (ButtonBox.getGlobalBounds().contains(mousePos))
      {
         ButtonState = BTN_HOVER;
         if (Mouse::isButtonPressed(Mouse::Left))
         {
            ButtonState = BTN_ACTIVE;
         }
      }
      if (ButtonState == BTN_IDLE)
         ButtonBox.setFillColor(idleColor);
      else if (ButtonState == BTN_HOVER)
         ButtonBox.setFillColor(hoverColor);
      else if (ButtonState == BTN_ACTIVE)
         ButtonBox.setFillColor(activeColor);

   }
}

void Button::updateEvented(Vector2f mousePos, Event event, bool fullColor)
{
   ButtonState = BTN_IDLE;
   if (ButtonS.getGlobalBounds().contains(mousePos))
   {
      ButtonState = BTN_HOVER;
      if (event.mouseButton.button == sf::Mouse::Left)
      {
         ButtonState = BTN_ACTIVE;
      }
   }
   if (fullColor)
   {
      if (ButtonState == BTN_IDLE)
         setColorB(idleColor);
      else if (ButtonState == BTN_HOVER)
         setColorB(hoverColor);
      else if (ButtonState == BTN_ACTIVE)
         setColorB(activeColor);
   }
   else
   {
      if (ButtonState == BTN_IDLE)
         ButtonS.setColor(idleColor);
      else if (ButtonState == BTN_HOVER)
         ButtonS.setColor(hoverColor);
      else if (ButtonState == BTN_ACTIVE)
         ButtonS.setColor(activeColor);
   }

}

void Button::render(RenderTarget* target)
{

   if (ButtonBoxAct)
      target->draw(ButtonBox);
   //target->draw(ButtonS);
   target->draw(ButtonT);
}

in short it just creates rectangleshape and text, chekcs its collision with mouse and returns it in "isPressed". My problem here is that when i try to create a vector with buttons it starts to freeze in some moments also taking up a lot of memory at these, i do it like this:
in game start function:

(click to show/hide)

for (int i = 0; i < 32; i++)
{
   int x = windowSize.width / 10 + i * 60;
   int y = windowSize.height / 1.7;
   if (i > 10)
   {
      y = windowSize.height / 1.5;
      x = windowSize.width / 10 + i * 60 - 10 * 60;
   }
   if (i > 19)
   {
      y = windowSize.height / 1.35;
      x = windowSize.width / 10 + i * 60 - 18 * 60;
   }
   if (i > 26)
   {
      y = windowSize.height / 1.23;
      x = windowSize.width / 10 + i * 60 - 24 * 60;
   }

   keyboardButtons.push_back(Button(x, y, 40, 40, alphabet, "", Color::White, Color::Yellow, Color::Blue));
}

in game update function:

(click to show/hide)

for (int i = 0; i < keyboardButtons.size(); i++)
{
   keyboardButtons.setFont(&font);
   keyboardButtons.updateEvented(mousePosView);
   keyboardButtons.ButtonBoxfunc(true, mousePosView, 5, Color::Black);
         if (keyboardButtons.isPressed())
         {
            //something
         }

}

at start i initialize buttons right to vector and in update check if button is pressed, the updateEvented checks collision and changes button states and buttonBoxfunc changes button color also helping to check collision creating box to collide with mouse
help me please to fix these freezes

Title: Re: checking collisions with array of objects takes too much
Post by: johnnywz00 on June 26, 2024, 10:23:01 pm

I confess I haven't thoroughly read through your code, but I note that in your initialization portion you may be incurring a lot of redundancy the way the `if` statements are written.
I would suggest the form:

if(i>26){}
else if(i>19) {}
else if(i>10 {}
else {}

Title: Re: checking collisions with array of objects takes too much
Post by: Hapax on June 26, 2024, 11:08:11 pm

I wouldn't actually say it's just redundant. Rather, it's likely incorrect.

For example, if "i" is 27, all of those ifs would be executed.

So, the if...else if...else if...else is likely the best choice here as Johnny mentioned.


As an added bonus, the expressions: (ButtonState == BTN_HOVER) and (ButtonState == BTN_ACTIVE) evaluate to booleans. Therefore, since you return true if the boolean is true, you can simply return the expression directly.
e.g.:

const bool Button::isPressed() const
{
   return (ButtonState == BTN_ACTIVE);
}

As for freezing, how and when are you executing those two loops?
I noticed that you are loading a font in with each creation of a Button so that's 32 fonts loaded with that first "i" loop. Loading fonts can be a slow process so it's my guess that it's that that's causing the slow-down.

The other "i" loop sets a font within the loop. It's possible that this may also cause a delay if the fonts are being rendered for the first time. This is not anywhere near as slow as loading though so fix that first ;)

One thing you should note is that the Button should not know or care what the font is (so should not be loading it itself), especially since you give the ability to set it externally.
Instead, load the font outside of the Button class and pass a pointer to it only. This way it will loaded only once and each button can use the same one(s).

You should likely pass the font to the Button class during construction along with all its other parameters.