void Draw::DrawTile(int number, int x, int y){
sf::Sprite tex(mTiles.at(number));
tex.setPosition((float)x*10,(float)y*10);
mWindow->draw(tex);
}void Draw::LoadTile(const string str){
sf::Image texture;
sf::Texture ftexture;
texture.loadFromFile(str);
sf::Color ColorKey(255,255,255);
texture.createMaskFromColor(ColorKey);
ftexture.loadFromImage(texture);
mTiles.push_back(ftexture);
}window.clean()
DrawTiles() //Draws the Tiles I want to draw
window.display()
string strfromint(int input)
{
stringstream inputs;
inputs<<input;
return inputs.str();
}
int main()
{
Game mGame;
Draw mDraw;
sf::RenderWindow window(sf::VideoMode(640, 480), "SFML works!");
mDraw.Init(&window);
sf::Text text("Hello SFML");
sf::Clock mClock;
mClock.restart();
while (window.isOpen())
{
sf::Event event;
if (window.pollEvent(event))
{
if (event.type == sf::Event::Closed)
window.close();
}
text.setString(strfromint((int)mClock.getElapsedTime().asMilliseconds()));
mClock.restart();
window.clear();
mGame.DrawGame(&mDraw);
window.draw(text);
window.display();
}
return 0;
}class Game{
std::vector<Room*> mRooms;
public:
void Game::DrawGame(Draw *nDraw){
for(unsigned int i=0;i<mRooms.size();++i)
mRooms.at(i)->DrawRoom(nDraw);
}
};class Room{
private:
int sizex;
int sizey;
int posx;
int posy;
int **tilemap;
int **walkmap;
public:
Room(int sx,int sy,int px,int py)
{sizex=sx;
sizey=sy;
posx=px;
posy=py;
tilemap=new int*[sizey];
for(int i=0;i<sizey;++i)
tilemap[i]=new int[sizex];
for(int i=0;i<sizex;++i)
for(int j=0;j<sizey;++j)
tilemap[j][i]=10;
walkmap=new int*[sizey];
for(int i=0;i<sizey;++i)
walkmap[i]=new int[sizex];
for(int i=0;i<sizex;++i)
for(int j=0;j<sizey;++j)
walkmap[j][i]=0;
};
~Room();
void DrawRoom(Draw* nDraw)
{
for(int i=0;i<sizex;++i)
for(int j=0;j<sizey;++j)
nDraw->DrawTile(tilemap[j][i],i+posx,j+posy);
}
};
class Draw {
private:
vector<sf::Texture> mTiles;
public:
int Init(sf::RenderWindow* nWindow);
void DrawTile(int number,int x,int y);
};
shortend unimportant parts and added function definitions to declarations
You could use std::string(int) instead, in most cases an int will cast to a string automatically anywayAre you really sure? :-X
Where is the vector filled? Any why std::vector<Room*> instead of std::vector<Room>?In the function Game::Genworld() wich is called in the constructor and builds 25 rooms.
works perfectlyint **walkmap;Looks dangerous. Why no containers? Use new and delete as rarely as possible.
I'll change this to iteratorsmRooms.at(i)
because I wanted to return an errorvalue when an image wasnt found.(Image loading is done inside this)int Init(sf::RenderWindow* nWindow);Why don't you use the constructor?
Room* because i dont know how to create objects dynamically without the new operatorDon't create them dynamically, there's no need to. std::vector already manages memory in a dynamic way. That is, you can insert or remove elements at any time.
works perfectlyEven if you do everything correctly (including deallocation), using nested new[] it is a complicated, error-prone and even inefficient way of storing objects in a 2D container. You need a lot of low-level boilerplate code to make it work, and you're still not safe for many cases (especially exceptions). Please use the RAII idiom and store the objects in a STL container like std::vector, you can also use only a one-dimensional vector and map 2D indices to 1D. That is more efficient because you only have one allocation/deallocation, a linear memory layout and thus less cache misses at iteration, furthermore there's a smaller memory overhead.
Don't create them dynamically, there's no need to.
for(int i=0;i<5;++i)
for(int j=0;j<5;++j)
mRooms.push_back(new Room(10,10,10*i,10*j));
How am I able to do this without pointers?