SFML community forums

General => SFML development => Topic started by: Gnawme on January 06, 2023, 07:04:55 am

Title: PR for issue 2312
Post by: Gnawme on January 06, 2023, 07:04:55 am

I'd like to submit a PR addressing issue #2312 (Remove defaulted or empty, non-virtual destructors): https://github.com/SFML/SFML/issues/2312

The changes are in the branch feature/clang-tidy-modernize. I started by introducing a small set of the modernize-* checks into the .clang-tidy file to mark constructors/destructors as =default and =delete  as appropriate, then removed the non-virtual =default destructors.

Arguably, =default constructors should be removed as well, since the compiler will generate them anyway.

Title: Re: PR for issue 2312
Post by: eXpl0it3r on January 06, 2023, 09:16:16 am

Note that there's already a PR open: https://github.com/SFML/SFML/pull/2321

But the clang tidy part would still be interesting to see.
So I suggest you just open a PR and then we can go from there. :)

Title: Re: PR for issue 2312
Post by: Gnawme on January 06, 2023, 05:12:45 pm

Thanks, I opened https://github.com/SFML/SFML/pull/2334