Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Try passing a negative number to setScale().
Cheers once again! Works beautifully.I read you can't use list.erase() while iterating using a C++11 range loop, but how would I go about doing it then?Use a conventional iterator loop like in good old times. You can even deduce the type with auto.My game segfaults when using erase while iterating.Assign the return value of erase() to the iterator, and make sure you don't increment the iterator in the cases where you erase.
Instead of std::vector<std::unique_ptr<T>>, it would be easier to use a different container such as std::list<T> or std::deque<T>.
With C++11, you can deduce the type by replacing std::vector<...>::iterator with auto, or even better, use the range-based for loop:for (Projectile& p : _projectileArray)
{
p.update();
CheckBulletCollision(p);
}
You don't need to pass the smart pointer around, just pass around a reference to the smart pointer's object.Sorry for the double-posting, but just to be sure that I understood what happened. Could you explain to me why the other sprites suddenly turned white when erasing a BulletPistol() from the std::vector array?
Changevoid Engine::CheckBulletCollision(std::unique_ptr<Projectile> projectile, int i)
...
CheckBulletCollision(_projectileArray[i], i)
Tovoid Engine::CheckBulletCollision(Projectile& projectile, int i)
...
CheckBulletCollision(*_projectileArray[i], i)
You don't need to pass the smart pointer around, just pass around a reference to the smart pointer's object.
Changevoid Engine::CheckBulletCollision(std::unique_ptr<Projectile> projectile, int i)
...
CheckBulletCollision(_projectileArray[i], i)
Tovoid Engine::CheckBulletCollision(Projectile& projectile, int i)
...
CheckBulletCollision(*_projectileArray[i], i)
I assume that this now means that the array, _projectileArray, now holds pointers to the BulletPistol class rather than a BulletPistol class itself. Is this correct?
Yes, and since you are using a smart pointer you do not need to worry about memory leaks, the smart pointer will automatically delete the BulletPistol class when it goes out of memory.QuoteIf so, how would the push_back look?_projectileArray.push_back(std::unique_ptr<Projectile>(new BulletPistol(...)));
$ make all && ./main.x64
g++ -std=c++11 -Wno-switch -Iinclude -c cpp/game.cpp
cpp/game.cpp: In member function ‘void Engine::Update()’:
cpp/game.cpp:121:52: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = Projectile; _Dp = std::default_delete<Projectile>]’
CheckBulletCollision(_projectileArray[i], i);
^
In file included from /usr/include/c++/4.8.1/memory:81:0,
from cpp/stdafx.h:17,
from cpp/game.cpp:2:
/usr/include/c++/4.8.1/bits/unique_ptr.h:273:7: error: declared here
unique_ptr(const unique_ptr&) = delete;
^
In file included from cpp/game.cpp:6:0:
cpp/game.h:22:10: error: initializing argument 1 of ‘void Engine::CheckBulletCollision(std::unique_ptr<Projectile>, int)’
void CheckBulletCollision(std::unique_ptr<Projectile> projectile, int i);
^
make: *** [game.o] Error 1
Just to be sure, you suggest to use a std::unique_ptr rather than std::vector?
No, use a std::unique_ptr<BulletPistol> with a std::vector<T>. So in the end you have std::vector<std::unique_ptr<BulletPistol>>.
You have a couple things going.Just to be sure, you suggest to use a std::unique_ptr rather than std::vector?_projectileArray.push_back(newBullet);
When you store your class in the array like that you are actually copying the BulletPistol class into the array (and thus when the array/vector is resized your copying your BulletPistol class again). Use a std::unique_ptr<BulletPistol> instead with your array to avoid copying.
And you should reread the tutorial on textures and pay close attention to the end about minimizing your textures. You are loading a new texture for every BulletPistol instance when you should already have it loaded and be reusing the same texture.