Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
May I ask for the title of the book?
And some hints concerning forum posts for the next time: Please use a descriptive thread title ("Need help with a problem in my game" is one of the most generic titles ever), and don't quote the full message if it's just above. You can also usetags for syntax highlighting.
Thanks
So what's the problem now? In your last post you stated that you "just tested it out". This looks like everything is fine.
If it isn't, you need to describe your current problem
If it's just the same as above (only one coin drawn): Your function draw_coins() is only called once per loop and only draws a single coin. So if you want to draw all coins you just have to loop over your vector and draw all spawned coins.
By the way: There are several things you could improve.
At first and foremost: EDIT: I've just seen that the formatting is wrecked by pastebin. The "RAW paste data" is ok.Pretty formatting! Your code is a mess. Just use consistent(!!!!!) and simple indendation (2 spaces, 4 spaces, 1 tab per block, just as you like, but be consistent).
And please get rid of those #pragma region things. Although they should make the code more readable, they clutter it more than necessary.
And then, the content: Why do you have a std::vector of somehow "constant" size? Why don't you use it the way it is supposed and push_back every new object? You could for example add newly spawned coins to the vector and remove any coins that would be collected or somehow moved offscreen. This would simplify drawing a lot! Just loop through the vector (google for C++11 for-range-loops) and draw each object. Bang, there you are.
You are making your code more complicated than necessary. KISS: Keep it simple and stupid
It seems you have a programming background somehow based on a mashup of C and C++. Where did you learn to program? Did you read a book? There is much potential for improvement, young padawan
I will try this when I find the time. My codes are usually more complicated than necessary Uhm.. I learned C++ more or less from a book. I havent even finished it completely but I plan to read it from 0 in the next time. Furthermore i will try to programm more useful programs for me to improve my experience.
I just tested it out
vector<sf::RectangleShape>coins(12, sf::RectangleShape(coin));
whichCoin = set_coins(coins, coinPosition);
while (mainWindow.isOpen())
{
loops = 0;
if(frameClock.getElapsedTime().asMilliseconds() >= updateRate && loops < maxFrameskip)
{
frameClock.restart();
coins[whichCoin].move(-2.5, 0);
if(coins[whichCoin].getPosition().x + 50 <= mainWindow.getSize().x - 50)
{
whichCoin = set_coins(coins, coinPosition);
}
loops++;
}
... continue of the while loop
}
int set_coins(vector<sf::RectangleShape>& object, int position)
{
int maxSpawn = 0; //max spawnable coins per column
int setSpawn[12]; //sets the spawn for each of the 12 coins
srand(time(NULL)); //reset the previous random numbers
for(int a = 0; a <= 11; a++)
{
setSpawn[a] = rand() % 2; //set 0 or 1 for each of the 12 coins
//cout << setSpawn[a] << endl; //test to check the spawns
}
for(int i = 0; i < object.size(); i++)
{
if(maxSpawn < 1) //allow only 1 coin to spawn per column
{
if(setSpawn[i] == 1) //if the spawn of the coin is 1
{
object[i].setSize(sf::Vector2f(50, 50));
object[i].setFillColor(sf::Color::Green);
object[i].setPosition(position, i*50);
return i;
}
}
maxSpawn = maxSpawn + setSpawn[i];
}
}
void draw_coins(sf::RenderWindow& window, vector<sf::RectangleShape>& object, int position)
{
window.draw(object[position]);
}