Messages

1

Graphics / Re: Compiler warnings on windows when compiling from source

« on: October 11, 2021, 01:05:02 am »

Yep, fixed indeed Thanks

2

Graphics / Re: Compiler warnings on windows when compiling from source

« on: October 10, 2021, 09:25:08 pm »

Thanks, Shall I make a PR which will get rid of those warnings? - I have already silenced them on my SFML fork.

3

Graphics / Compiler warnings on windows when compiling from source

« on: October 10, 2021, 05:36:05 pm »

Hi!
I got 5 warnings when I was compiling SFML from source on MSVC. I know that 3 of them are known (deprecated -backward compatibility) and already supressed them with compiler flags. But the remaining 2:

...\SFML\SFML\src\SFML\Graphics\Font.cpp(394): warning C4244: 'initializing': conversion from 'const int' to 'float', possible loss of data [...\SFML\SFML\build\src\SFML\Graphics\sfml-graphics.vcxproj]

...\SFML\SFML\src\SFML\Graphics\Font.cpp(395): warning C4244: 'initializing': conversion from 'const int' to 'float', possible loss of data [...\SFML\SFML\build\src\SFML\Graphics\sfml-graphics.vcxproj]

I've added explicit conversion from int to float (static_cast) in those lines and warnings are no longer presented. Is there any reason not to cast it explicitly? I saw same issues on SFML github repo during CI windows checks.