Show Posts
1
General discussions / Review of simple Input Manager.
« on: August 05, 2019, 09:20:51 pm »
Hello! 
I am during my first project in SFML in which I decided to create some kind of game engine that I can use in my future games. I made an action manager which has its members marked as static.
.hpp file:
.cpp file:
And then I've got a simple class which handles real-time input
My question is if it even makes sense? In case of checking input I'd need to type "if(ActionManager::isActionPressed("someAction")) doSomeStuff" which is not the most convinient style but I have no idea how it could be rearranged. Any help would be appreciated.
I am during my first project in SFML in which I decided to create some kind of game engine that I can use in my future games. I made an action manager which has its members marked as static.
.hpp file:
#include "Input/input.hpp"
#include <unordered_map>
namespace WhitE {
class ActionManager
{
public:
static void addAction(const std::string&, sf::Keyboard::Key);
static void addAction(const std::string&, std::vector<sf::Keyboard::Key>);
static void deleteAction(const std::string& actionName);
static bool isActionPressed(const std::string& actionName);
static bool isMouseButtonPressed(sf::Mouse::Button);
private:
inline static Input mInput;
inline static std::unordered_map<std::string, std::vector<sf::Keyboard::Key>> mKeyboardMap;
};
}
#include <unordered_map>
namespace WhitE {
class ActionManager
{
public:
static void addAction(const std::string&, sf::Keyboard::Key);
static void addAction(const std::string&, std::vector<sf::Keyboard::Key>);
static void deleteAction(const std::string& actionName);
static bool isActionPressed(const std::string& actionName);
static bool isMouseButtonPressed(sf::Mouse::Button);
private:
inline static Input mInput;
inline static std::unordered_map<std::string, std::vector<sf::Keyboard::Key>> mKeyboardMap;
};
}
.cpp file:
#include "Input/actionManager.hpp"
#include "Logger/logs.hpp"
namespace WhitE {
void ActionManager::addAction(const std::string& actionName, sf::Keyboard::Key key)
{
mKeyboardMap.insert(std::make_pair(actionName, std::vector<sf::Keyboard::Key> {key}));
WE_LOG_INFO(actionName + " action was added to the manager.");
}
void ActionManager::addAction(const std::string& actionName, std::vector<sf::Keyboard::Key> keys)
{
mKeyboardMap.insert(std::make_pair(actionName, keys));
}
void ActionManager::deleteAction(const std::string& actionName)
{
if (mKeyboardMap.find(actionName) != mKeyboardMap.end())
mKeyboardMap.erase(actionName);
else
WE_LOG_WARNING("WhitE: Key of map cannot be found!");
}
bool ActionManager::isActionPressed(const std::string& actionName)
{
auto keys = mKeyboardMap.at(actionName);
for (const auto& key : keys)
{
if (mInput.isKeyPressed(key))
return true;
}
}
bool ActionManager::isMouseButtonPressed(sf::Mouse::Button button)
{
return mInput.isMouseButtonPressed(button) ? true : false;
}
}
#include "Logger/logs.hpp"
namespace WhitE {
void ActionManager::addAction(const std::string& actionName, sf::Keyboard::Key key)
{
mKeyboardMap.insert(std::make_pair(actionName, std::vector<sf::Keyboard::Key> {key}));
WE_LOG_INFO(actionName + " action was added to the manager.");
}
void ActionManager::addAction(const std::string& actionName, std::vector<sf::Keyboard::Key> keys)
{
mKeyboardMap.insert(std::make_pair(actionName, keys));
}
void ActionManager::deleteAction(const std::string& actionName)
{
if (mKeyboardMap.find(actionName) != mKeyboardMap.end())
mKeyboardMap.erase(actionName);
else
WE_LOG_WARNING("WhitE: Key of map cannot be found!");
}
bool ActionManager::isActionPressed(const std::string& actionName)
{
auto keys = mKeyboardMap.at(actionName);
for (const auto& key : keys)
{
if (mInput.isKeyPressed(key))
return true;
}
}
bool ActionManager::isMouseButtonPressed(sf::Mouse::Button button)
{
return mInput.isMouseButtonPressed(button) ? true : false;
}
}
And then I've got a simple class which handles real-time input
#include "Input/actionManager.hpp"
#include <SFML/Window.hpp>
namespace WhitE {
class Input
{
private:
bool isKeyPressed(sf::Keyboard::Key key) { return sf::Keyboard::isKeyPressed(key); }
bool isMouseButtonPressed(sf::Mouse::Button button) { return sf::Mouse::isButtonPressed(button); }
friend class ActionManager;
};
}
#include <SFML/Window.hpp>
namespace WhitE {
class Input
{
private:
bool isKeyPressed(sf::Keyboard::Key key) { return sf::Keyboard::isKeyPressed(key); }
bool isMouseButtonPressed(sf::Mouse::Button button) { return sf::Mouse::isButtonPressed(button); }
friend class ActionManager;
};
}
My question is if it even makes sense? In case of checking input I'd need to type "if(ActionManager::isActionPressed("someAction")) doSomeStuff" which is not the most convinient style but I have no idea how it could be rearranged. Any help would be appreciated.
sorry for being gone but I am on the Holidays right now so I can't even check my dependencies but I hope that is the case and I'll make it work. I'll reply as soon as I'm home.