Welcome, Guest. Please login or register. Did you miss your activation email?

Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Topics - christoph

Pages: [1] 2
1
General / Patch for gcc-4.6
« on: May 17, 2011, 12:42:35 am »
Hi!

one of my colleagues at Debian pkg-games wrote a patch for building SFML with gcc-4.6:

Code: [Select]

From: Evgeni Golov <evgeni@debian.org>
Subject: [PATCH] debian/gcc-4.6

Properly link with GCC 4.6.
#include <cstddef> everywhere.
Closes: #625031

Signed-off-by: Evgeni Golov <evgeni@debian.org>

---
 include/SFML/Audio/Music.hpp           |    1 +
 include/SFML/Audio/Sound.hpp           |    1 +
 include/SFML/Audio/SoundBuffer.hpp     |    1 +
 include/SFML/Graphics/PostFX.hpp       |    1 +
 include/SFML/Graphics/RenderWindow.hpp |    1 +
 include/SFML/Graphics/Sprite.hpp       |    1 +
 include/SFML/Graphics/String.hpp       |    1 +
 include/SFML/System/ResourcePtr.inl    |    1 +
 src/SFML/Graphics/Font.cpp             |    1 +
 src/SFML/Graphics/Image.cpp            |    1 +
 10 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/include/SFML/Audio/Music.hpp b/include/SFML/Audio/Music.hpp
index 0b8f70d..3320676 100755
--- a/include/SFML/Audio/Music.hpp
+++ b/include/SFML/Audio/Music.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/Audio/SoundStream.hpp>
 #include <string>
 #include <vector>
diff --git a/include/SFML/Audio/Sound.hpp b/include/SFML/Audio/Sound.hpp
index 7cb8002..5a46481 100755
--- a/include/SFML/Audio/Sound.hpp
+++ b/include/SFML/Audio/Sound.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/System/Resource.hpp>
 #include <SFML/System/Vector3.hpp>
 #include <SFML/Audio/AudioResource.hpp>
diff --git a/include/SFML/Audio/SoundBuffer.hpp b/include/SFML/Audio/SoundBuffer.hpp
index 023e5aa..2db29ad 100755
--- a/include/SFML/Audio/SoundBuffer.hpp
+++ b/include/SFML/Audio/SoundBuffer.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/System/Resource.hpp>
 #include <SFML/Audio/AudioResource.hpp>
 #include <string>
diff --git a/include/SFML/Graphics/PostFX.hpp b/include/SFML/Graphics/PostFX.hpp
index c875377..be2200a 100755
--- a/include/SFML/Graphics/PostFX.hpp
+++ b/include/SFML/Graphics/PostFX.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/Graphics/Drawable.hpp>
 #include <SFML/Graphics/Image.hpp>
 #include <istream>
diff --git a/include/SFML/Graphics/RenderWindow.hpp b/include/SFML/Graphics/RenderWindow.hpp
index 088e368..b2154cc 100755
--- a/include/SFML/Graphics/RenderWindow.hpp
+++ b/include/SFML/Graphics/RenderWindow.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/Graphics/Image.hpp>
 #include <SFML/Graphics/RenderTarget.hpp>
 #include <SFML/Window/Window.hpp>
diff --git a/include/SFML/Graphics/Sprite.hpp b/include/SFML/Graphics/Sprite.hpp
index 9d47bb4..deb6bab 100755
--- a/include/SFML/Graphics/Sprite.hpp
+++ b/include/SFML/Graphics/Sprite.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/System/Resource.hpp>
 #include <SFML/Graphics/Drawable.hpp>
 #include <SFML/Graphics/Rect.hpp>
diff --git a/include/SFML/Graphics/String.hpp b/include/SFML/Graphics/String.hpp
index b0ca81b..6b9c483 100755
--- a/include/SFML/Graphics/String.hpp
+++ b/include/SFML/Graphics/String.hpp
@@ -28,6 +28,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/System/Resource.hpp>
 #include <SFML/System/Unicode.hpp>
 #include <SFML/Graphics/Drawable.hpp>
diff --git a/include/SFML/System/ResourcePtr.inl b/include/SFML/System/ResourcePtr.inl
index dbfcd0d..7bda5f1 100755
--- a/include/SFML/System/ResourcePtr.inl
+++ b/include/SFML/System/ResourcePtr.inl
@@ -22,6 +22,7 @@
 //
 ////////////////////////////////////////////////////////////
 
+#include <cstddef>
 
 ////////////////////////////////////////////////////////////
 /// Default constructor
diff --git a/src/SFML/Graphics/Font.cpp b/src/SFML/Graphics/Font.cpp
index 36c4c28..350c0cc 100755
--- a/src/SFML/Graphics/Font.cpp
+++ b/src/SFML/Graphics/Font.cpp
@@ -25,6 +25,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/Graphics/Font.hpp>
 #include <SFML/Graphics/FontLoader.hpp>
 #include <iostream>
diff --git a/src/SFML/Graphics/Image.cpp b/src/SFML/Graphics/Image.cpp
index 14346fb..8b18fb7 100755
--- a/src/SFML/Graphics/Image.cpp
+++ b/src/SFML/Graphics/Image.cpp
@@ -25,6 +25,7 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <cstddef>
 #include <SFML/Graphics/Image.hpp>
 #include <SFML/Graphics/ImageLoader.hpp>
 #include <SFML/Graphics/RenderWindow.hpp>
--


2
Python / 1.6 python release?
« on: April 10, 2010, 12:53:55 pm »
Hi all!

the python binding for 1.5 doesn't build against 1.6. is there a chance of seeing a 1.6 python binding soon?If it's all that is needed I can of course prepare a patch to make it build again (1.6 doesn't introduce new stuff the binding needs to forward, right?)

3
General discussions / cheeseburger.ttf
« on: April 10, 2010, 11:53:45 am »
Hi Laurent!

You seem to include a for-sale comercial font in the samples directory:

./samples/bin/datas/pong/cheeseburger.ttf
./samples/bin/datas/post-fx/cheeseburger.ttf

This font is sale for $$$ on http://www.fontbros.com/cgi-bin/commerce.cgi?preadd=action&key=FOLI-CHEE

4
General discussions / Handling of code-copies from needed 3rd party libraries in s
« on: October 01, 2009, 02:27:18 pm »
Hi Laurent!

A long time ago I think we talked about not shipping libraries like glew zlib or libpng in sfml where you argued you want these for the users to ease building. While I'd argue that at least zlib, libpng, libjpeg and maybe the glew stuff is easily available for Linuxers I accept your choice.

However the current status requires a rather large patch for me that needs updating for new SFML releases and others might also prefer using libraries from their system (e.g. because some bug is fixed there?) I'd propose the following:

  • In the SFML code use the paths that would be used on a normal Unix/Linux system like #include <GL/glew.h>
  • Place the needed libraries somewhere in the top-level directory, arranging the includes and stuff in the same way they're found on Unixes and referenced from Code
  • Use -I so the build works with these shipped copies


This would mean all that is needed to not use the shipped copies is a rm -rf used-libraries/*

Optionally the Makefiles could get a option to disable (selectively?) some of the copies as needed.

Hopefully this won't cause much disruption in SFML so if you think a implementation like that will have a chance getting into SFML I'd start creating the patches.

Regards

Christoph

5
C / CSFML and _SYSTEM_ macros
« on: October 01, 2009, 01:21:13 pm »
Hi laurent!

I just learned CSFML uses it's own System detection Code in Config.h which does not include any FreeBSD at all although some headers check for CSFML_SYSTEM_FREEBSD. Of course this can be adde to CSFML's Config.h as well but I was just wondering why the detection Code is there 2 times and would prefer if CSFML just uses SFML's code -- potentially split into another Header if needed.

Additionally CSFML in sfml2 trunk has a non-existent libdir, it points to CSFML/lib currently so Either a ../ in CSFML/src/SFML/Makefile is missing or a dir in CSFML (/me guesses the first is right)

Regards

Christoph

P.S.: because we're at it, CSFML doesn't build in sfml2 trunk currently

-> http://random.christoph-egger.org/.sfml2-ftbfs-2

6
Feature requests / [Patches] Resolve all symbols
« on: September 15, 2009, 03:43:01 pm »
Hi Laurent!

I have created a set of 2 patches which resolves all symbols needed in SFML libraries. This has 2 advantages: The libraries become dlopen() able and you don't need to remember linking against some library in your application if you don't use it directly. Patches are against sfml2 branch and tested locally on my system.

http://random.christoph-egger.org/.sfml-2/

7
Feature requests / 2 small patches + build problem in sfml2 branch
« on: September 07, 2009, 11:20:51 am »
Hi laurent!

This time I made the patches against sfml2 trunk so I don't bring in patches by accident that are actually already applied ;)

These patches address SFML and CSFML -- python uses a completely different system and I haven't had a look at the other languages ;)

First of all, SFML2 does not build for me, not sure if you already know it. The error message is at http://random.christoph-egger.org/.sfml2-ftbfs

http://random.christoph-egger.org/.sfml-2/relativ-ln.patch changes the symlinks from libsfml-*.so to libsfml-*.so.* to relative ones. That's the only problem I have currently to use you're DESTDIR implementation unchanged, would be great if it can go in!

http://random.christoph-egger.org/.sfml-2/usr-local.patch might be a bit more controversial. The LSB (LinuxStandardBase) subsystem FHS (Filesystem layout) clearly defines that /usr/{bin,include,share,lib} is only to be used by the package management solutions. Your makefiles installing into /usr/{lib,include} are illegal according to the LSB and can cause real troubles with package managers which all assume they are the only ones to write to prefix /usr.

Changing that to /usr/local would make SFML LSB compliant and package managers won't overwrite a hand-installed libsfml with a system one. As /usr/local comes before /usr on all but more-than-5-years-old RHEL users will get handinstalled Versions of SFML by default when linking their application and a systme installed one is available as well.

Thanks

Christoph

8
Feature requests / GNU/kFreeBSD support
« on: August 24, 2009, 05:42:14 pm »
Heya Laurent!

include/SFML/Config.hpp currently checks for __FreeBSD__ to detect FreeBSD kernels. The SFML_SYSTEM_FREEBSD works here for me on Debian GNU/kFreeBSD (FreeBSD Kernel + GNU Userland) just fine if I enable the build.

Could you please change the check so it also uses SFML_SYSTEM_FREEBSD if __FreeBSD_kernel__ is defined?

A patch for 1.5 is http://random.christoph-egger.org/kfreebsd.diff

9
General discussions / SFML on (k)FreeBSD
« on: June 15, 2009, 08:13:47 am »
As I noticed there was some FreeBSD Code added to SFML I'm playing with it on a Debian GNU/kFreeBSD System (That's GNU userland but a FreeBSD kernel).

Unfortunately the Config.hpp does not yet detect this BSD kernel situation, the stuff GCC defines here is

http://random.christoph-egger.org/bsd32
http://random.christoph-egger.org/bsd64

would you consider applying somthing like http://random.christoph-egger.org/sfml-bsd-patch after I have confirmed it is working as expected?

10
Python / Bug in doc or PySFML
« on: March 29, 2009, 11:56:38 pm »
The Python Tutorial seems to not work for me as Clear() does not run with no arguments. Placing an sf.Color(0,0,0) as argument works.

Is this an PySFML bug or an documentation bug?

(Python 2.4 that is)

11
Python / Download link nonfunctional?
« on: January 25, 2009, 03:26:49 pm »
Is it only me or does the dl link for PySFML 1.4 not work?

12
Feature requests / CSFML + g++ 4.3
« on: December 15, 2008, 05:05:21 pm »
Hi!

While SFML itself builds on g++-4.3 in version 1.4 this is currently not the case for CSFML. You could consider the following patch:

http://patch-tracking.debian.net/patch/series/view/libcsfml/1.3-2/cstring_ftbfs.patch

13
Feature requests / Please enable make mrproper from toplevel
« on: November 02, 2008, 12:19:58 am »
Hi

No longer hijacking http://www.sfml-dev.org/forum/viewtopic.php?p=4718 ;)

Could you add an mrproper target in your toplevel Makefile (calling the ones in samples and src/SFML? I was experimenting with this so I have an patch (it's an no-brainer but anyway):

Code: [Select]
diff a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -13,3 +13,7 @@ install:
 clean:
  @(cd ./src/SFML && $(MAKE) $@)
  @(cd ./samples  && $(MAKE) $@)
+
+mrproper:
+ @(cd ./src/SFML && $(MAKE) $@)
+ @(cd ./samples  && $(MAKE) $@)


Thanks

  Christoph

14
Graphics / [LINUX] Failed to create an OpenGL context for this window
« on: October 04, 2008, 10:22:11 am »
Anyone seen something like

Code: [Select]
Failed to create an OpenGL context for this window
Failed to create an OpenGL context for this window
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  8 (X_MapWindow)
  Resource id in failed request:  0x0
  Serial number of failed request:  31
  Current serial number in output stream:  31
Locking assertion failure.  Backtrace:
#0 /usr/lib/libxcb-xlib.so.0 [0x7fd897f9b97c]
#1 /usr/lib/libxcb-xlib.so.0(xcb_xlib_lock+0x15) [0x7fd897f9ba15]
#2 /usr/lib/libX11.so.6 [0x7fd89b830420]
#3 /usr/lib/libX11.so.6(XESetCloseDisplay+0x43) [0x7fd89b812693]
#4 /usr/lib/libGL.so.1 [0x7fd8a066f7b2]

before?

An Idea what could have caused this? To me, it looks like some very early OpenGL / X11 initlialization.

15
General discussions / SFML 1.3 -- sonames
« on: June 22, 2008, 01:44:57 pm »
Hi

It's me complaining again ;)

I have noticed you kept the soname for SFML in your 1.3 release while it clearly is API and ABI incompatible[1]. Could you please increase the soname at least for your 1.4 release?

I also have some changes (e.g. linking the sfml library files against each other as needed so they can ba loaded at runtime and one does not have to add an -lsfml-system when only using sfml-window) would you like me to have them applied to latest svn and providing an diff here? If wanted I would also setup an autotools build system for linux/unix systems.

[1] http://wiki.linuxquestions.org/wiki/Library-related_Commands_and_Files

Pages: [1] 2