1
DotNet / What should be the criteria for .Net Core Merge? (Community Input)
« on: November 22, 2017, 10:19:48 pm »
Since the PR has been open for a couple of month, i would like to know what should be the criteria to merge the PR?
https://github.com/SFML/SFML.Net/pull/143
Exemples :
Please feel free to express your opinion!!!
TL;DR of PR
https://github.com/SFML/SFML.Net/pull/143
Exemples :
- Works on Windows, Mac, Linux
- Works/tested on Windows ONLY (same as current repo?)
- Works on Windows, Linux (because we cannot test Mac?)
- ...
Please feel free to express your opinion!!!
TL;DR of PR
- Make SFML.Net work with .Net Core 2.0
- Native Windows, Linux, Mac support (.Net Core 2.0)
- Exemples in the repo using OpenTK (OpenGL in C#) are broken because OpenTK hasn't been ported to .Net Core (we might leave 1 OpenGL exemple "broken" until the OpenTK team port to .Net Core and clean up other exemples using it)
- The PR has been tested on Windows and Ubuntu 16.04 (please feel free to test other OS, distro and architecture like ARM...)