Welcome, Guest. Please login or register. Did you miss your activation email?

Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - FRex

Pages: 1 2 [3] 4 5 ... 123
31
General / Re: Having trouble with sf::Drawable inheritance
« on: April 05, 2019, 02:43:51 am »
If a virtual method is not defined (in sf::Drawable it's pure) that might cause an error like you're getting. You should add at least an empty {} for draw in that class and then see if the error is still there.

32
General / Re: Having trouble with sf::Drawable inheritance
« on: April 04, 2019, 10:10:52 pm »
Do you have your NormalParticle's draw defined (not just declared) or not?

33
General / Re: Having trouble with sf::Drawable inheritance
« on: April 04, 2019, 08:57:45 pm »
You didn't implement draw at all.

34
SFML website / Certificate Error
« on: March 27, 2019, 04:19:57 am »
Hey, so I see there is a fresh Let's Encrypt certificate on the website (en., fr., www. and sfml-dev.org itself) with starting date of 26 of May. ;)

The issue is that the en. and fr. subdomains are not listed in Subject Alternative Name so the forums display a big ugly warning about it. :-X

Edit: I see it's been fixed now. :P

35
Audio / Re: Issues compiling statically with the audio library
« on: March 24, 2019, 06:39:47 pm »
Did you ever try the ones in SFML/extlibs/libs-msvc-universal?

36
Audio / Re: Issues compiling statically with the audio library
« on: March 24, 2019, 06:33:07 pm »
I looked at just accepted answer before, I read that one now and it's all correct, that array and FILE changing sizes is really bad. The only way to fix it is to recompile with newer VC++ after all.

37
Audio / Re: Issues compiling statically with the audio library
« on: March 24, 2019, 06:10:52 pm »
I edited my last answer, there is workaround code in your SO link, I'm not sure what you mean by it being experimental and x86 specific.

38
Audio / Re: Issues compiling statically with the audio library
« on: March 24, 2019, 06:07:37 pm »
The issue is due to dependencies being built using an older MSVC. For __iob_func there is a work around listed in accepted answer on SO that you linked. I'm not sure what you mean by x86 specific or experimental.

39
Audio / Re: Issues compiling statically with the audio library
« on: March 20, 2019, 06:03:38 am »
Then try add 'legacy_stdio_definitions.lib' to the libs you're linking (it's part of MSVC)? It says so in your stack overflow link and with another prebuilt library (freetype) this problem also exists but is hidden/doesn't apply due to a funny quirk.

40
Graphics / Re: Alternative to texture.update(pixelBuffer)? (too slow)
« on: March 11, 2019, 03:39:33 am »
Maybe OpenGL pixel unpack buffer could help here? SFML doesn't provide that though so you'd have to write your own code for that.

41
General discussions / Re: SFML featured in...
« on: February 26, 2019, 01:49:43 am »
Finnish YouTuber Bisqwit used SFML in two recent videos:

https://www.youtube.com/watch?v=SktXhGElf7w

https://www.youtube.com/watch?v=Jcymn3RGkF4

42
SFML development / Re: Removing dependency binaries
« on: February 23, 2019, 11:16:10 pm »
If user wants to link to system's dynamic binaries then doesn't it mean the bundled deps aren't built at all/CMake doesn't generate their projects/makefiles?

Is that related to SFML_USE_SYSTEM_DEPS? What does that one even do? If I check it in CMake with VS 2017 the Audio still references ogg, flac and others and Graphics references FT.

Right now the deps are static libs, get linked into dlls but not static libs (they were a long time ago but it was changed and now user must link them when linking SFML statically).

43
SFML development / Re: Removing dependency binaries
« on: February 23, 2019, 02:04:50 pm »
STB updates (2 years ago) produced huge diffs. No one ever mentioned that being a problem in any way and they are neatly stashed in a 'STB updated to x.yy' commit by themselves. Ideally no commits other than 'updated some lib or other to some version' will ever touch a given lib's dir. If a lib needs to be patched urgently because it derails SFML I'd rather it be done inline in the main repo too.

Most people using git might not even know submodules exist and if they do they will often not know the command off the top of their head (I fit into latter category). It's 1 extra command and more CMake checks for no real benefit to anyone.

The size of FreeType doesn't matter. Bigger (and less compressible) binary files are in the repo already. Amount of files doesn't matter either, git handles it, it's not some prohibitive amount (like thousands of files) and they will be stashed away in own dir and only touched by some 'FT updated to X.YY' commits. To build SFML you'd need to fetch it all anyway most of the time.

What do we care for git histories of deps? These libraries are ostensibly stable API solid C libs that will be updated rarely to some given x.y.z stable release version (so just how binaries were now except not in 5 copies of each anymore and without needing to build it all), not kept up to master or their repo where we need to debug them ourselves.

Even Qt repo linked in the first post doesn't use submodules for the third party libs. They dump all third party code into one repo and add a file saying what version it is in the root of their dirs. They discard all the history and produce huge diffs. I've seen them use submodules in some other repo (with chromium submodule for web engine and with their 'super repo' that is all submodules, maybe more) but that makes more sense for them than for SFML.

It's one more parameter or command (that most people don't know off the top of their head and even ones who know it might forget it exactly since it's such a rare operation to clone and build SFML) and extra checks in CMake, all for no real benefit/solving no real problem. These source dirs should be treated exactly like the binaries are now (except for there being like 5 version of the binaries) - totally opaquely, just changed once in a while in their own commit and used in builds (to build lib that then gets linked/installed) if the user doesn't check that 'use system deps' flag.

The reason why binaries are gonna be removed is not to ever work on these libs code but to make it more convenient to build SFML everywhere so adding submodules throws that small gain out the window instantly. Binaries were never a "I don't know what this binary's git history is" problem so just dumping C into the main repo is no worse from that standpoint either.

44
SFML development / Re: Removing dependency binaries
« on: February 23, 2019, 01:34:17 am »
I'd prefer just dumping all the C deps sources into the main repo. I can think of no upsides but only downsides to using submodules.

With submodules a simple git clone no longer clones the repo 'properly', a single commit/checkout is no longer all that you need to build SFML as it was in a given point in time and so on. It's not obvious at first what's even going on, what commands to use to get all the files in place, etc.

These C sources will be treated exactly like the binaries are now - dumped in there, used in configs where they are needed and updated once in a while. The advantage of few repos all pointing at one lib repo they all use doesn't apply here either since SFML is the sole 'end code' repo using all these libs.

Quote
Remove the binaries from the git repository, but instead include the source code of said dependencies and instrument our CMake build system to build the dependencies when building SFML itself.
This is exactly what I'd advise ('include the source code' as in - into the single SFML repo, no submodules).

Quote
This has the advantage that we cut down the size of the repo, remove the binary building maintenance cost on our side, can add more dependencies without mentioned concerns and if people want to, they can more easily modify or update the dependencies for their own needs.
Exactly. In (unlikely) case a change to a dep lib is needed there will be no wondering how main repo, submodules, commits, forks and so on all interact nor chasing submodule repos commit logs to find out who, when, where and why changed a thing (and what SFML commit said to reference that new commit's hash via the submodule). It'll all be a single SFML commit history instead.

Also, I assume since the binaries are gonna remain in the git history it'll be more like stopping the growth of repo size from each time new binaries appeared, not making it smaller, but it's still good.

45
Window / Re: Window resizing problem
« on: February 22, 2019, 06:39:23 pm »
He is using callbacks instead of events. SFML and SDL have events, GLFW has callbacks. I prefer events myself too. If you really want one over the other you can easily implement it yourself in own code in all these libraries without modifying them.

Pages: 1 2 [3] 4 5 ... 123
anything