Abstract sf::Proxy

[korczurekk]

Idea
- Abstract sf::Proxy;
- Simple implementation for widely used proxies (like those: https://incloak.com/proxy-list/), HTTP(s)/SOCKS 5 support out-of-the-box would be pretty nice;
- ::setProxy(const sf::Proxy&) methods in proper classes.

Use cases
Abstract sf::Proxy:
Allows programmer to implement more complicated proxies, that may not be used by big amount of people so there's no need to implement those in SFML.

Simple implementation for widely used proxies:
1. Can be used to forward connections through 'normal', popular proxies;
2. Sample of proper inheritance of sf::Proxy class.

::setProxy(const sf::Proxy&) methods in proper classes
You all most likely know why. 

Sooo… what do you think?

[Mario]

While it would certainly be nice to have, I'd also consider it too specific and complex to add to a generic (networking) API. There are tons of other possible additions that are most likely more useful to a bigger audience, yet simply not possible due to lack of time. I think even a pure and simple HTTP server would be more likely than a proxy, but there's a similar problem.

When does a multimedia program need a built-in proxy? The chances should be next to nil. So the more realistic approach would be using a standalone proxy library or implementation and extend that using SFML to fulfill whatever you have in mind.

[korczurekk]

I looked again at the source code and it actually appears to be quite easy, max 100-150 lines of code and no need to write setProxy method(s), are there chances, that a PullRequest adding proxy support would be accepted? If so, I could explain my point of view and idea of implementation, and then eventually write it.

[Mario]

If you need that functionality anyway, just create your own fork of SFML and add it. Once done you can always ask again (e.g. by bumping this thread) or creating a pull request.

[eXpl0it3r]

The main point that's missing for me is a concert use case, like what does "to implement more complicated proxies" even mean? What's a more complicated proxy?

Since you mentioned SOCKS, should SFML implement a server or a client or both?

What is that setProxy function part of?

What's an "Abstract sf::Proxy"?

[korczurekk]

If you need that functionality anyway, just create your own fork of SFML and add it. Once done you can always ask again (e.g. by bumping this thread) or creating a pull request.

I thought about it, but after some time I would not get new SFML features, so it's not really good idea.

like what does "to implement more complicated proxies" even mean? What's a more complicated proxy?

A proxy that requires something more than one message at the beginning to keep it active and working properly.

Since you mentioned SOCKS, should SFML implement a server or a client or both?

Client, SFML (and C++) aren't good choice to write servers and no one would really write such thing using those two.

What is that setProxy function part of?

Any class that could connect through proxy, like sf::Http, sf::Ftp or sf::TcpSocket.

What's an "Abstract sf::Proxy"?

Abstract base class that would be inherited by sf::HttpProxy, sf::SockProxy etc.

[Mario]

If you need that functionality anyway, just create your own fork of SFML and add it. Once done you can always ask again (e.g. by bumping this thread) or creating a pull request.

I thought about it, but after some time I would not get new SFML features, so it's not really good idea.

Except that isn't true. You could still just fetch changes from the official master using an alternative remote. All changes and fixes would be applied, you'd just have to fix occasional merge conflicts (if any; if you're adding stuff only rather than modifying existing files).

[korczurekk]

If you need that functionality anyway, just create your own fork of SFML and add it. Once done you can always ask again (e.g. by bumping this thread) or creating a pull request.

I thought about it, but after some time I would not get new SFML features, so it's not really good idea.

Except that isn't true. You could still just fetch changes from the official master using an alternative remote. All changes and fixes would be applied, you'd just have to fix occasional merge conflicts (if any; if you're adding stuff only rather than modifying existing files).

I'd have to change all classes using network (not much, a few lines) so… well, I have probably no choice, so I just hope, that devs won't change too much in those classes soon. 

[bushjeann]

 In a nutshell, a proxy server, or simply a proxy, is a computer that acts as an intermediary between the user and the target server. First, the client connects to the proxy server and requests the desired resource on another server—for example, a mail or an Html page. The proxy either connects to the target server and retrieves the help or returns the resource from its cache. I use pirate bay because it is the most convenient proxy server and easy to use.