(Solved) RectangleShape.contains(...) does not compile for me / VS2017

[M74]

Hi,

please take a look at these 2 functions:

private:
        sf::RectangleShape m_shape;

        bool getIsMouseHover_A(int x, int y)
        {
                sf::FloatRect rect = m_shape.getGlobalBounds();
                return (x >= rect.left && x < rect.left + rect.width && y >= rect.top && y < rect.top + rect.height);
        }

        bool getIsMouseHover_B(int x, int y)
        {
                return (m_shape.getGlobalBounds().contains((float)x, (float)y));
        }
 

While method "_A" works fine the method "_B" does not even compile on my Visual Studio 2017.
The compiler complains about Line #81 in sf::RectInl.

    // Compute the real min and max of the rectangle on both axes
    T minX = std::min(left, static_cast<T>(left + width));
 

What`s the reason for this? Did i miss something?

Regards,
Mathias

[FRex]

What's the error message?

[M74]

Hi FRex,

please see the attachet screenshot of Visual Studio 2017. Please excuse, that it`s german version - but i think you`ll get the point.

Regards,
Mathias

[eXpl0it3r]

Sounds to me like your Visual Studio version is broken. Have you tried using it?

[M74]

As of yet i never had problems with my installation of VS and using SFML. But of course it really could be a problem here locally on my pc if no one can reproduce this compiler-errors.

[M74]

Now i tried the following combination of _A and _B:

        bool getIsMouseHover_C(int x, int y)
        {
                sf::FloatRect rect = m_shape.getGlobalBounds();
                return rect.contains(sf::Vector2f((float)x, (float)y));
        }
 

But also here i get errors on ".contains". Strange, eh...? 

[FRex]

This is sketchy AF... Try using std::min and std::max in own code. Did you include Windows.h somewhere?

[M74]

Mh okay. But where do i have to use std::min/max? I thought that this code-example is as simple as it could be xD You are absolutely right, i use Windows Header in my project!

[FRex]

Well duh... really, that one? Windows.h (the Windows from Microsoft OS WinApi header, not the SFML/Window.hpp one, that one is fine) has min and max macros that crap up the std:: stuff in C++: https://stackoverflow.com/questions/11544073/how-do-i-deal-with-the-max-macro-in-windows-h-colliding-with-max-in-std

[M74]

Ahhh, thank you! That`s the problem!