C++ SFML Collision Bug

[Personwwww]

I wrote some collision code that responds to collisions. So, I put it in a function. Then, the response to the collision stopped working but the collision detection still worked.

P.S OG_INFO means printf.

#include "Collision.h"

void OpenGEC::Collision::AddCollider(Sprite& sprite, Sprite& _sprite)
{

    if (sprite.getGlobalBounds().intersects(_sprite.getGlobalBounds())) {
        Vector2f pos_ = _sprite.getPosition();
        Vector2f pos = sprite.getPosition();
        if (pos.y > pos_.y) {
            pos.y++;
            sprite.setPosition(pos);
            _sprite.setPosition(pos_);
            OG_INFO("{0},{1}", pos.x, pos.y);
        }
        else if (pos.y < pos_.y) {
            pos.y--;
            sprite.setPosition(pos);
            _sprite.setPosition(pos_);
            OG_INFO("{0},{1}", pos.x, pos.y);
        }
        else if (pos.x > pos_.x) {
            pos.x++;
            sprite.setPosition(pos);
            _sprite.setPosition(pos_);
            OG_INFO("{0},{1}", pos.x, pos.y);
        }
        else if (pos.x < pos_.x) {
            pos.x --;
            sprite.setPosition(pos);
            _sprite.setPosition(pos_);
            OG_INFO("{0},{1}", pos.x, pos.y);
        }
    }
}

[Hapax]

What doesn't work exactly? It's still detecting the collision fine?

What you are doing with pos and the unit increments, we can only guess without more information.

[Personwwww]

What doesn't work exactly? It's still detecting the collision fine?

What you are doing with pos and the unit increments, we can only guess without more information.

The collision detection is working fine but I am stuck on how to react.

[Hapax]

How do you want it to react? How is it currently reacting?

[Personwwww]

It barely is reacting at all. I want it to react by stopping the object that is colliding.

[Hapax]

They are both colliding. I presume you want to 'stop' the first one when it collides with the second?

To stop, simply stop moving it.

However, I gather you probably want to move it to where it was no longer colliding?

There are a number of approaches.
1) Easiest is to just put it back to where it was before it collided.
2) Another would be to work out which direction (of the four main directions) you want it be 'ejected' from the other object and then place it so that their edges match (this seems to be what you're going for).
3) A more accurate way would be trace the move between the two positions and calculate the position where they would intersect. You can do this after colliding and return it to this position, or before colliding when working out if it will be collided in advance.

As an example of (2), if you wanted to 'expel' a sprite (sprite) to the left, you would set it's x position so that it's right side matches the other object's (_sprite) left side. Something like this:

sf::Vector spritePosition{ sprite.getPosition() };
spritePosition.x = _sprite.getPosition().x - sprite.getTexture().getSize().x;
sprite.setPosition(spritePosition);

Note that getTexture().getSize().x is the width of the sprite unless the sprite is scaled.
Also, we presume no rotation is involved.