sf::Musics' threads

[FRex]

Can few sf::Music instances play using single sf::InputStream?
If yes, does that require sf::InputStream implementation to be thread safe?

[Laurent]

Can few sf::Music instances play using single sf::InputStream?

If you look at what sf::InputStream does, it is obvious that it cannot work with several "clients": it has the current reading position. And multiple musics would require multiple reading positions.

[FRex]

Right, and what is read supposed to return on error? Returning 0 caused me access violation, returning -1 like in all others works and just errors with sane message about file being corrupt. Also maybe it's a good idea to make more apparent that read assumes that read pointer is advanced by the amount of bytes read, maybe I'm stupid but that wasn't that obvious to me. And assumption(or maybe I debugged my stream wrong but I didn't see a single seek() call in my test for sf::Image from png) that streams start with read pointer at 0 can be somewhat harmful if I'd want to load few things from same stream in succession, I'd have to call seek(0) myself in between or it'd error out with corrupt file message.

[Laurent]

Right, and what is read supposed to return on error?

It's documented.

Also maybe it's a good idea to make more apparent that read assumes that read pointer is advanced by the amount of bytes read

Yep, probably.

And assumption(or maybe I debugged my stream wrong but I didn't see a single seek() call in my test for sf::Image from png) that streams start with read pointer at 0 can be somewhat harmful if I'd want to load few things from same stream in succession, I'd have to call seek(0) myself in between or it'd error out with corrupt file message.

Hmm yes, you're right. I think you should create an issue on the tracker to summarize your feedback, so that I can work on it later.

[FRex]

It's documented.

Not here... but that's old docs..
http://www.sfml-dev.org/documentation/2.0/classsf_1_1InputStream.php#a8dd89c74c1acb693203f50e750c6ae53
Not even here in the holy c++ source code itself.
https://github.com/SFML/SFML/blob/master/include/SFML/System/InputStream.hpp
The other 3 all say to return -1 on error in both of these though. Or does that mean that I should return 0 on error since I read 0 bytes?

[Laurent]

It's in the tutorial... ... ok, shame on me

I just added it.

[FRex]

Awesome. Here's the issue, I hope I wrote it alright:
https://github.com/SFML/SFML/issues/349

It's in the tutorial... ... ok, shame on me

I should have remember it was tutorial, I had in mind I've seen sf::InputStream using std::FILE somewhere but couldn't remember where.