Joystick axes query per joystick under macOS enhancement suggestion

[AshleyF]

Dear All,

I was wondering if it might be possible to change:

unsigned int axes = sf::Joystick::AxisCount;

to:

unsigned int axes = sf::Joystick::AxisCount(joystickNumber);

such that it's possible to test exactly how many axes are available on a given joystick, or, going further with it, would it be possible to return appropriate information on a given joystick such that I'd immediately know what axes were available?

The reason why I'm suggesting this is because under macOS, irrespective of the joystick being tested, it always returns 8 as the answer to the query.

Kind regards,

AshleyF

[Hiura]

This is an enum; that's why the value is always the same. Modifying it at runtime is therefore not possible. Also, changing it to a function would break API so this is a no go. BUT we could have a static `getAxisCount` function similar to `getButtonCount`, yes. Or probably better yet: `bool hasAxis(joystick, axis)`.

Edit: Apparently we already have a hasAxis function...

[Mario]

Fully agree.

To further add: The enum value is there to get the maximum number of axes supported by SFML, not the actual number of any particular controller.

[Hiura]

Ashley, feel free to open an issue on github linking to this discussion. Additionally, if you have time, a PR would be more than welcome, even if you can provide only the Mac implementation (we'll try to find some other good fellows for Linux and Windows implementations).

[Laurent]

http://www.sfml-dev.org/documentation/2.4.1/classsf_1_1Joystick.php#a268e8f2a11ae6af4a47c727cb4ab4d95

[Hiura]