All sprites showing as white boxes.

[JohnnyMccrum]

Not sure what I'm doing wrong here.

when I display my textures with

window.draw(Spritesheet.at(1));

they all appear as white squares.

I have these variables in my main.h

//the main spritesheet.

Image sheetIMG;

//array to hold circles.
vector<CircleShape> Circles;

//array to hold sprites.
vector<Sprite> Spritesheet;

below is the offending code.

int LoadSpritesheet()
{
   //make sure spritesheet exists, then loads it into an image.

   Texture sheet;
   if (!sheet.loadFromFile("Sprites/A.png"))
   {
      return 0;
   }
   else
   {
      sheetIMG = sheet.copyToImage();
      MakeSprites();
      return 1;
   }
      

}

void MakeSprites()
{
   //turns the entire spritesheet into 8x8 modular sprites.

   Texture tex;

   int c = 0, r = 0;

   for (int i = 0; i <= (sheetIMG.getSize().x * sheetIMG.getSize().y) / 64; i++)
   {

      if (i == 125)
      {

         Sprite sprsdsds;
      }

      if (!tex.loadFromImage(sheetIMG, IntRect(0, 0, 8, ))
         break;
      else
      {
              Sprite spr;
              spr.setTexture(tex);
         Spritesheet.push_back(spr);
         c += 8;
         if (c == 16) { r++; };

      }
   }
   
   

         
}

[eXpl0it3r]

Take a look at the official tutorial which explains this problem: The white square problem

[JohnnyMccrum]

that doesn't really solve my issue though. How do I fix the pointer issue?

I'm rather new to pointers.

Surely sheetIMG should still store those textures as it's declared in my header?

[eXpl0it3r]

Get your favorite C++ resource or a good C++ book and read the chapter about references. Not really something we here can or should teach you.

As long as you want to use the sprite, the textures need to exist. As such you should first think about who owns the textures and how can you save them for as long as the sprite uses it (a general solution would be to use something like Thor's resource holder).

Ah and if you aren't already, you should use a class instead of having global variables which will sooner than later blow up in your face.

[JohnnyMccrum]

Thanks for being of absolutely no help.

Fixed it myself, there's absolutely no need to patronize me.

last time I post here.

[Arcade]

Glad you got it figured out, but I'm not sure why you took offense to eXpl0it3r's post. I thought he provided pretty solid advice. He explained exactly what your problem was (your texture was going out of scope while the sprite still needed it) and pointed out that Thor has classes to take care of resource handling for you if you are struggling with it.

Keep in mind that this is a SFML help forum, not a C++ help forum. That is why he pointed you towards other places to learn more about pointers and object lifetimes.

[ZiyadCodes]

I still don't understand the right way to fix the sprites appearing as white.
Here is my Bullet.cpp script:

(click to show/hide)

#include <Bullet.h>
#include <iostream>

Bullet::Bullet(float _x, float _y, float _speed, float _rotation, float _damage)
{
   this->bulletTexture.loadFromFile("Resources/Syringe.png");
   this->bulletSprite.setTexture(this->bulletTexture);

   this->rotation = _rotation;
   this->damage = _damage;
   this->speed = _speed;
   this->radius = 5;
   this->x = _x;
   this->y = _y;

   this->bullet = sf::CircleShape(this->radius);
}

void Bullet::update()
{
   float horizontal = -sin(this->rotation * (3.14f / 180.f)) * this->speed;
   float vertical = cos(this->rotation * (3.14f / 180.f)) * this->speed;

   this->x -= horizontal;
   this->y -= vertical;

   this->bulletSprite.setPosition(this->x, this->y);
   this->bullet.setPosition(this->x, this->y);
}

void Bullet::render(sf::RenderWindow& window)
{
   window.draw(this->bulletSprite);
}

and here is my Bullet.h script:

(click to show/hide)

#pragma once

#include <SFML/Audio.hpp>
#include <SFML/Graphics.hpp>
#include <SFML/Network.hpp>
#include <SFML/System.hpp>
#include <SFML/Window.hpp>

class Bullet
{
public:
   Bullet(float _x, float _y, float _speed, float _rotation, float _damage);

   sf::Texture bulletTexture;
   sf::Sprite bulletSprite;
   float rotation;
   float damage;
   float radius;
   float speed;
   float x;
   float y;

   sf::CircleShape bullet;

   void render(sf::RenderWindow& window);
   void update();
};

I even tried to do something like this in the update function:

(click to show/hide)

if (!this->bulletTextured)
   {
      this->bulletSprite.setTexture(this->bulletTexture);
      this->bulletTextured = true;
   }

But still like it kind of worked but didn't at the same time. Sometimes the bullets would appear as a white box and sometimes they work with the texture and sometimes they work at the first second after they are shot and they turn to a white box, this is very confusing

and my sprite still appears as a white square.
The only way I managed to get the sprite to work properly is when I put sprite.setTexture() in the update method.
Is there a correct way to fix this problem?

[kojack]

It depends on how you are using the Bullet objects.
This is just a guess about how you are handling it, but if you are pushing them into a vector, like std::vector<Bullet>, then that's the problem.
Sprites store a pointer to the texture you attach to them. This means the Texture object can't move in memory, the pointer to the texture in the sprite will break.
When an object is added to a vector, it makes a duplicate at a different location, so the texture pointer is not valid in the duplicate (points to the original Bullet, not the one in the vector). Also adding things to a vector will make the vector occasionally resize, which requires moving everything around (breaking the texture pointers again).
Although as I said, that's just a guess.

I find the easiest way to deal with Texture objects is to allocate them on the heap (using new) and handle them with pointers. This stops duplication and moving around in memory, so the binding from the sprite won't break.
I'd change the header to have:
sf::Texture *bulletTexture;

and the constructor to have:
bulletTexture = new sf::Texture;
bulletTexture->loadFromFile("Resources/Syringe.png");
bulletSprite.setTexture(*bulletTexture);

Even better would be to load the texture once somewhere (like a resource manager) and reuse it. Unlimited sprites can share a single texture. Right now every Bullet is reloading the png file and storing a copy of it's data.
(on a side note, I'd remove all the this-> bits, they aren't hurting but they also aren't doing anything)

[ZiyadCodes]

Thank you so much. You helped me fix the problem

THANKS     ~     THANKS     ~     THANKS     ~     THANKS     ~     THANKS     ~     THANKS     ~     THANKS