I need a little help with my Image Manager

[MarthKoopa]

This is a little image manager I wrote, but I don't know what I'm doing wrong.  Shouldn't this work?  (am using SFML 2.0 with Visual Studio 2010 Ultimate)

Code: [Select]


class zImage : public Image{
    public:
    string Name;
    string Category;

    void Load(string GetCategory, string getName){
        Name         = getName;
        Category     = GetCategory;
        LoadFromFile ( "Graphics/" + Category + "/" + Name + ".png" );
        SetSmooth    ( false );
    }
};

class ImageManager{
    std::vector<zImage> ImageList;

    public:
    zImage &GetImage(string GetCategory, string GetName){
        for ( long index = 0; index < (long)ImageList.size(); index++ ) {
            if (ImageList[index].Category == GetCategory){
                if (ImageList[index].Name == GetName){
                    return ImageList[index];
                }
            }
        }

        // Image was not found, so create it and return it
        zImage tempImage;
        tempImage.Load(GetCategory, GetName);
        ImageList.push_back(tempImage);
        return tempImage;
    }
}Images;


Example usage:

Code: [Select]


Sword.SetImage(Images.GetImage("Swords", "Iron"));


I get an unhandled exception and it brings me to this code in MutexImpl.cpp

Code: [Select]


////////////////////////////////////////////////////////////
void MutexImpl::Lock()
{
    EnterCriticalSection(&myMutex);
}


[Laurent]

Code: [Select]

       zImage tempImage;
        tempImage.Load(GetCategory, GetName);
        ImageList.push_back(tempImage);
        return tempImage;
Here you return a reference to the local/temporary image, not the copy that is stored inside the list.
You compiler should warn you about that

[Mindiell]

Is there any constructor of your class ?
Does it work after 5 seconds or 2 ?

[Laurent]

Don't use std::vector, it may have to move its elements elsewhere in memory when it needs to grow, invalidating all the references that you returned previously.

You should use a std::map, using the name as the key.