[solved]Problem with App.IsOpened

[asiajek]

Hi, I'm learning C++ so I wrote a small class to manage SFML easier :-D

Code: [Select]

#ifndef ENGINE_H
#define ENGINE_H
#include "global.h"

class Engine
{
    public:
        Engine(int iWidth, int iHeight, int iBits, const char* sTitle);
        void Update(float fTime);
        void Delete();
        bool GetIsOpened();
        virtual ~Engine();

        float fElapsedTime;
    protected:
    private:
        sf::RenderWindow App;
        sf::Input Input();
        sf::Event Event;
        sf::Clock Clock;
};

#endif // ENGINE_H


Code: [Select]

#include "include/Engine.h"

using namespace sf;

Engine::Engine(int iWidth, int iHeight, int iBits, const char* sTitle)
{
    RenderWindow App(VideoMode(iWidth, iHeight, iBits), sTitle);
    App.SetActive(true);
    std::cout << iWidth << iHeight << iBits << sTitle << std::endl;
}

void Engine::Update(float fTime)
{
    fElapsedTime += Clock.GetElapsedTime();
    Clock.Reset();

    while(App.GetEvent(Event))
    {
        if (Event.Type == Event::Closed || Event.Key.Code == Key::Escape) Engine::Delete();
    }

    App.Clear();
    App.Display();
}

bool Engine::GetIsOpened()
{
  return App.IsOpened();
}

void Engine::Delete()
{
   App.Close();
}

Engine::~Engine()
{
    App.Close();
}


Code: [Select]

#include "include/global.h"
#include "include/Engine.h"

#define fTIME_STEP 0.01f
#define iWIDTH  1024
#define iHEIGHT 768
#define iBITS   32
#define sTITLE  "Panzer-panzer"

using namespace std;

int main()
{
    Engine Engine(iWIDTH, iHEIGHT, iBITS, sTITLE);

    while (Engine.GetIsOpened())
    {
        Engine.Update(fTIME_STEP);
    }

    Engine.~Engine();
    system("Pause");
    return 0;
}

But I have problem with App.IsOpened() function - it returns 0 (false) causing my game to close just after opening (while(Engine.GetIsOpened)). Why is that?
PS. If you saw any other mistakes in the code - write it here. I'm still learning

[Hiura]

because this line of code

Code: [Select]

RenderWindow App(VideoMode(iWidth, iHeight, iBits), sTitle); doesn't do what you expected. ;-)

You're creating here a new variable hiding your object's 'app' attribute. In order to create your window correctly you have to use the initialisation list of the constructor because RenderWindow is non-compiable. (Google it).

So the correct code should looks like :

Code: [Select]

Engine::Engine(int iWidth, int iHeight, int iBits, const char* sTitle)
: App(VideoMode(iWidth, iHeight, iBits), sTitle)
{
}


[asiajek]

Thank you very much!!! It works just fine!
But, do I need to put this initialization list in the header(declaration) also? I googled some pages but nobody writes about separating declaration and implementation in the context of initialization list.

[devlin]

No you don't - you can use the initialization list in a cpp-file and just leave the definition in the header file.

This is how you set const-variables within classes for instance.

[asiajek]

Thank you! I'll read more about it.
(How can I close the topic? Or should I ask moderators?)
Ok, so, dear Moderators please close this topic

[Hiura]

You don't need to close the topic but you can edit your first message and add [solved] at the beginning of the title.  :wink: