sf::Shape Compile() is private.

[The_Cleaner]

Laurent,
I was wanting to make a few shapes using the sf::Shape as the base class, but since the Compile() is private and not protected, this is not as clean as it could be. While I know I can (and already have successfully) create a function which creates the shapes I want, and I could even derive since you put in the check to compile before rendering, I assume that since you explicitly call Compile() in your static functions, there is a benefit of doing that over letting the render function handle it automatically. That said, was there a reason you made Compile() private?

Love SFML by the way, keep up the excellent work!  
thanks,
Ben (AKA The_Cleaner)

[Laurent]

I assume that since you explicitly call Compile() in your static functions, there is a benefit of doing that over letting the render function handle it automatically

Not really. The only difference is that it is compiled during its creation rather than the first time you draw it.

[The_Cleaner]

Thanks for the fast reply Laurent. So that said, compiling at creation if possible would generally be preferred, so why not make Compile() protected, or even public for that matter! Not sure if I'm missing something about the class... Are we meant not to derive from sf::Shape?

[Laurent]

Well...

Is there an actual problem with that? No
Will the sf::Shape class be totally different in a few days? Yes
So should we really start a long discussion about this Compile() function now? No

[The_Cleaner]

Fair enough...

I know SFML2 is still in development and many things will change. So one final question on the "future plans" for sf::Shape.

You just said the class will likely be changed soon, does that mean you will be likely adding more static shape functions, or is that outside the scope of what you are trying to provide in the sf::Shape class?

Or are you just referring to the simple nature of using something that is in development, and that it is simply in flux!

Again thanks for your time, I really like the API, so not really trying to give you a hard time or anything!

[Laurent]

In fact the new API is ready, and will be pushed soon. So I can already tell you about the details.

I've changed my strategy for shapes: there's now a base class (sf::Shape) and one derived class for each type of shape: circle, rectangle, convex polygon, star, ... All the complicated code is implemented in the base class, derived ones simply provide the list of points, and hide all this stuff behind a dedicated API (Circle::SetRadius, Rectangle::SetSize, ...).

[The_Cleaner]

Excellent!
I look forward to the release then.
Thanks again for the info.

[OniLinkPlus]

In fact the new API is ready, and will be pushed soon. So I can already tell you about the details.

I've changed my strategy for shapes: there's now a base class (sf::Shape) and one derived class for each type of shape: circle, rectangle, convex polygon, star, ... All the complicated code is implemented in the base class, derived ones simply provide the list of points, and hide all this stuff behind a dedicated API (Circle::SetRadius, Rectangle::SetSize, ...).

HUZZAH!

[bananu7]

finally...