RenderManager, encapsulate sf::RenderWindow

[xmax3]

Hi ! I'm currently thinking about a "RenderManager" for my game, it would encapsulate a sf::RenderWindow (with method to draw on it, etc, etc) and the video settings (whether the particles, vsync, fullscreen are enabled or not for example).

My question is: Am-I better to recode all access method of my sf::RenderWindow (draw, getView, setMaxFps, etc) and then when I'll draw my game I'll pass the RenderManager to the "object.draw(...)" method ? It's a lot of method to recode though, so I don't know if it's a good thing...

I'm also using TGUI for the controls and it needs the sf::RenderWindow for drawing and probably for other stuffs like cursor position on the window, so I suppose I'm better to code an access method to the sf::RenderWindow, then I'll be able to pass it directly to the tgui::gui ?

I have the felling my questions are a bit simple, but I want to be sure I'm doing it right.
If you have any suggestion, I'm open to it. Thanks !

[Nexus]

What is your intention? If you build a wrapper that provides all the methods of sf::RenderWindow, then you're not really encapsulating it, so why not use it directly? When you design a new class, only provide the methods you need, not everything that might be useful one day. Keep interfaces small.

If you already have such a class, I'd try to move graphics-specific code into it. In a bigger project, the last thing you want is when every logic class or entity needs to know how to create and render its own sprite... There have been a lot of threads on separation between graphics and logics in this forum, you might be interested in them.

[xmax3]

If you build a wrapper that provides all the methods of sf::RenderWindow, then you're not really encapsulating it, so why not use it directly?

That was my worry. I'm going to rethink about that. If I have any questions I'll post them here.

There have been a lot of threads on separation between graphics and logics in this forum, you might be interested in them.

Yeah, that's a good idea. I'll be looking for it.

Edit: Just as an help for future viewers of this thread, I found this project on Nexus's git: https://github.com/Bromeon/TemporaryOutbreak