Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: Let There Be Light 2  (Read 120493 times)

0 Members and 1 Guest are viewing this topic.

DarkRoku12

  • Full Member
  • ***
  • Posts: 203
  • Lua coder.
    • View Profile
    • Email
Re: Let There Be Light 2
« Reply #120 on: February 08, 2016, 02:13:28 pm »
I can test it on Visual Studio 2013.
Want to i tried it know or better wait some days?
If you allow me, I will partner with you in this beautiful purpose.
I can test it on Visual Studio 2015 when Breush considers the moment has come.
Well, even if the project is not ready for release, I think the sooner, the better.
Because if there are some things I have to be careful about when coding, I'd like to know right now.

The repository has a CMake. It should be easy for you guys to test.
Let me know via an issue on GitHub or a pull request if you can fix it.

Thanks.

I patched the sf::Color( r , g , b , a ) paramter. VS++ gime and error for requering narrowing conversion.
Also noexcept with

#ifndef _MSC_VER
   #define NOEXCEPT noexcept
#else
   #define NOEXCEPT
#endif
 


But, there are no __declspec(dllexport) to create shared libraries. The compiler (VS2013) only generates the .dll, cause there is no exports, .lib archive is not generated.
I would like a spanish/latin community...
Problems building for Android? Look here

Cleroth

  • Newbie
  • *
  • Posts: 12
    • View Profile
    • Email
Re: Let There Be Light 2
« Reply #121 on: February 08, 2016, 03:44:52 pm »
#if !defined(_MSC_VER) || _MSC_VER >= 1900
   #define NOEXCEPT noexcept
#else
   #define NOEXCEPT
#endif
 
« Last Edit: February 08, 2016, 03:46:29 pm by Cleroth »

DJuego

  • Jr. Member
  • **
  • Posts: 50
    • View Profile
Re: Let There Be Light 2
« Reply #122 on: February 08, 2016, 03:47:26 pm »
Well.  I tested with Microsoft Visual Studio 2015 (x64)  and MinGW ( x86-64-win32-seh-rev0 gcc 5.3.0). Both attempts failed:-[

My system is Windows 10. It was used the last SFML (from git repository).

I attached the nmake and make outputs.

DJuego

Breush

  • Guest
Re: Let There Be Light 2
« Reply #123 on: February 08, 2016, 04:04:43 pm »
My system is Windows 10. It was used the last SFML (from git repository).

I attached the nmake and make outputs.

This just look like SFML not being linked in the program you're running.
Can you try with the option SFML_STATIC_LIBS set to true?

R23MJ

  • Jr. Member
  • **
  • Posts: 50
    • View Profile
Re: Let There Be Light 2
« Reply #124 on: February 08, 2016, 04:34:16 pm »
My apologies, I could have informed you that it was the lack of __declspec(dllexport). The only problems I had when building LTBL2 was the .lib was never built.

Breush

  • Guest
Re: Let There Be Light 2
« Reply #125 on: February 08, 2016, 04:53:17 pm »
But, there are no __declspec(dllexport) to create shared libraries. The compiler (VS2013) only generates the .dll, cause there is no exports, .lib archive is not generated.
My apologies, I could have informed you that it was the lack of __declspec(dllexport). The only problems I had when building LTBL2 was the .lib was never built.
OK, I'm really not used to Windows environments.
Can either of you do a pull request or send me (via PM) a diff (git diff or svn diff)?

Axcelsior

  • Newbie
  • *
  • Posts: 2
    • View Profile
Re: Let There Be Light 2
« Reply #126 on: February 17, 2016, 07:25:33 pm »
Hi, just found this and it looks amazing! I want to try and implement LTBL2 into a game im working on. Can anyone explain to me how i include it it my project? I know i can include the directory directly in my project but is there a way to include it as a library / additional include ?
When I just add the files to my project I have to change #include <LTBL\xxxxx> to #"include <LTBL\xxxxx>"

I am using VS btw.
« Last Edit: February 17, 2016, 07:32:14 pm by Axcelsior »

Axcelsior

  • Newbie
  • *
  • Posts: 2
    • View Profile
Re: Let There Be Light 2
« Reply #127 on: February 28, 2016, 10:13:52 pm »
1>Math.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall sf::ConvexShape::ConvexShape(class sf::ConvexShape &&)" (__imp_??0ConvexShape@sf@@QAE@$$QAV01@@Z) referenced in function "class sf::ConvexShape __cdecl ltbl::shapeFromRect(class sf::Rect<float> &)" (?shapeFromRect@ltbl@@YA?AVConvexShape@sf@@AAV?$Rect@M@3@@Z)


I get this when i try to compile in VS 2015

scayze

  • Newbie
  • *
  • Posts: 2
    • View Profile
    • Email
Re: Let There Be Light 2
« Reply #128 on: June 27, 2016, 10:49:57 pm »
Is there any way to use LTBL with vs 2015?
im trying to get it to work since some time. without any success. the .lib file wont generate & including all the source files into the project didnt work for me either :/

R23MJ

  • Jr. Member
  • **
  • Posts: 50
    • View Profile
Re: Let There Be Light 2
« Reply #129 on: June 30, 2016, 07:58:42 pm »
Is there any way to use LTBL with vs 2015?
im trying to get it to work since some time. without any success. the .lib file wont generate & including all the source files into the project didnt work for me either :/

It won't make windows files correctly, not sure why; including source files is your only option. We need to know what errors you are getting not "Didn't work for me either :/". What didn't work

Cleroth

  • Newbie
  • *
  • Posts: 12
    • View Profile
    • Email
Re: Let There Be Light 2
« Reply #130 on: June 30, 2016, 08:06:31 pm »
Is there any way to use LTBL with vs 2015?
im trying to get it to work since some time. without any success. the .lib file wont generate & including all the source files into the project didnt work for me either :/
We need to know what errors you are getting not "Didn't work for me either :/". What didn't work

You mean like "It won't make windows files correctly, not sure why"?

R23MJ

  • Jr. Member
  • **
  • Posts: 50
    • View Profile
Re: Let There Be Light 2
« Reply #131 on: July 02, 2016, 01:19:15 am »
You mean like "It won't make windows files correctly, not sure why"?

I am not asking for help, he is. I have my version working.

tony_kero

  • Newbie
  • *
  • Posts: 7
    • View Profile
Re: Let There Be Light 2
« Reply #132 on: July 13, 2016, 01:41:51 pm »
Hey ! you have done a really great job, i want to use it in my game engine but when compiling in VS2015 i got weird errors
Debug Win32:


G:\Projets\Node\Repository\external\LTBL2-master\LTBL2\source\ltbl\quadtree\QuadtreeOccupant.cpp(15): error C2248: 'ltbl::Quadtree::_outsideRoot' : impossible d'accéder à protected membre déclaré(e) dans la classe 'ltbl::Quadtree'

G:\Projets\Node\Repository\external\LTBL2-master\LTBL2\source\ltbl\quadtree\QuadtreeOccupant.cpp(25): error C2248: '
ltbl::Quadtree::_outsideRoot' : impossible d'accéder à protected membre déclaré(e) dans la classe 'ltbl::Quadtree'
 

this lines say "impossible to reach protected member in class ltbl::QuadTree" from QuadtreeOccupant.cpp(15 and 25)

EDIT: Solved but i had to edit l 54 of Quadtree.h and add "friend class QuadtreeOccupant;"
Anyway great work keep on !
« Last Edit: July 13, 2016, 01:45:53 pm by tony_kero »

Cmdu76

  • Full Member
  • ***
  • Posts: 194
    • View Profile
Re : Let There Be Light 2
« Reply #133 on: September 18, 2016, 11:51:52 pm »
Hi !

While working on my engine I wanted to improve as much as possible LTBL2.
I forked the main repository and reviewed ALL the code.

Changes (compared to the actual version) :
  • Light management : use create...() to create your light and add it to the system (no shared pointers used)
  • No more public variables access
  • Quadtree : rebuilt entirely
  • LightSystem : simplified render call and minor performance improvements
  • LightShape & LightPointEmission are updated with the quadtree
  • LightDirectionEmission has been simplified
  • Some performance improvements, based on Sayuri suggestion here : http://fr.sfml-dev.org/forums/index.php?topic=16895.msg138669#msg138669
  • Add resources direclty in C++ (PenumbraTexture, UnshadowShader & LightOverShapeShader)
  • Documentation : https://cmdu76.github.com/LTBL2
  • Two-files version, just add LetThereBeLight.cpp and LetThereBeLight.hpp

Here is the repository :
https://github.com/Cmdu76/LTBL2

Feel free to suggest or pull request

(The next feature I might add is normals)

If lolz123 can see this, can you tell me if I need to make a pull request ? As it changes almost all files, I wasn't sure you'll accept it..
« Last Edit: September 21, 2016, 08:36:08 am by Cmdu76 »

Retrospital

  • Newbie
  • *
  • Posts: 3
    • View Profile
    • Retrospital
    • Email
Re: Let There Be Light 2
« Reply #134 on: September 19, 2016, 05:46:29 pm »
Thank you so much for your work Cmdu76 !!!
I'm speaking in the name of all our dev team here, we were looking forward to the implementation of the Sayuri awake/turned on system within the LTBL because we couldn't figure out how to do it by ourselves...And it's also a very good news that you got rid of the shared pointers !

Hopefully this will help us resolve our performance issues haha !

Thanks again !

« Last Edit: September 19, 2016, 05:49:20 pm by Retrospital »

 

anything