Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: Forked SFML, merged grab_mouse  (Read 2928 times)

0 Members and 1 Guest are viewing this topic.

anthnich

  • Newbie
  • *
  • Posts: 34
    • View Profile
    • Long Division LLC
Forked SFML, merged grab_mouse
« on: December 11, 2014, 07:33:33 pm »
Not certain which forum to post this to.

I wanted to test and play with grab_mouse w/ the latest SFML revision, so I forked everything off and merged the two. I think I did everything correctly and my initial tests (integrated with my project) with Windows, Linux, & MAC OS X have been fine.

Here's the link to my fork if anyone wants to play around:

https://github.com/anthnich/SFML

Honestly, I'm not certain if you guys discourage this type of thing. So, if I made a faux pas, just let me know.

eXpl0it3r

  • SFML Team
  • Hero Member
  • *****
  • Posts: 11034
    • View Profile
    • development blog
    • Email
AW: Forked SFML, merged grab_mouse
« Reply #1 on: December 11, 2014, 11:03:01 pm »
SFML is open source and under the zlib/png license, so everything you did is okay.
Though everyone who understands a bit how Git works, can do this in a few seconds, so question is rather what use your repo has. ;)

But I am glad you tested the branch. We always need more testers. :)
« Last Edit: December 11, 2014, 11:15:31 pm by eXpl0it3r »
Official FAQ: https://www.sfml-dev.org/faq.php
Official Discord Server: https://discord.gg/nr4X7Fh
——————————————————————
Dev Blog: https://duerrenberger.dev/blog/

StormWingDelta

  • Sr. Member
  • ****
  • Posts: 365
    • View Profile
Re: Forked SFML, merged grab_mouse
« Reply #2 on: December 12, 2014, 01:51:49 am »
Just remember to leave documentation comments for those that come after you so we don't end up having to ask you what you were up to months down the road.  Teacher of mine got on me hard about that.   ::) Needless to say nice to see more people learning github and how to add to SFML. :)
I have many ideas but need the help of others to find way to make use of them.