New Shader class in SFML 2 to replace PostFx

[l0calh05t]

My rule is that context settings are only a hint, and if any of them is not supported then SFML will try to find the closest valid match. So no, no failure will happen. And you can request the actual settings that were used with Window::GetSettings().

About this:
When I request GL 3.0, I get a 3.0 context. Requesting a 3.1 context fails, but falls back to 2.0 instead of 3.0. I think the minor version should be lowered first.
Also, if I use an invalid MSAA level, the fallback fails (even though antialiasing usually works)

[Laurent]

When I request GL 3.0, I get a 3.0 context. Requesting a 3.1 context fails, but falls back to 2.0 instead of 3.0. I think the minor version should be lowered first

Yeah, maybe.

Also, if I use an invalid MSAA level, the fallback fails (even though antialiasing usually works)

Really? When AA fails I just lower the value and call the same function again and again, until it works. When 0 is reached, the execution is exactly the same as if you passed 0 directly.
Maybe you can run your program step-by-step in debug mode to see what happens in SFML?

[l0calh05t]

Looks like the error is in line 184 of ContextWGL.cpp:

mySettings.AntialiasingLevel = intAttributes[1] = 2;

this should actually be

mySettings.AntialiasingLevel = intAttributes[11] = 2;

[Laurent]

That's so stupid :shock:

Thank you very much, it's now fixed

[OniLinkPlus]

I got the debug binaries working. Blackness when I use RenderImage. Nothing in stderr, either.

[Laurent]

I got the debug binaries working. Blackness when I use RenderImage. Nothing in stderr, either.

What about the Shader sample? Does it work?

[OniLinkPlus]

I got the debug binaries working. Blackness when I use RenderImage. Nothing in stderr, either.

What about the Shader sample? Does it work?

Yes. It's probably a problem with sf::RenderImage, as that is where my problem is at.

[Laurent]

Yes. It's probably a problem with sf::RenderImage, as that is where my problem is at.

But the shader sample uses a RenderImage as well, so the problem might be from your code.

[Laurent]

When I request GL 3.0, I get a 3.0 context. Requesting a 3.1 context fails, but falls back to 2.0 instead of 3.0. I think the minor version should be lowered first.

Done in latest sfml2 revision.

[Oz1571]

After updating to the latest version, my game now freezes completely at

Screen.Create(mode, "oglgame", sf::Style::Resize | sf::Style::Close, settings);

If I set the opengl version to 2.x instead of 3.x, it works fine. I last updated less than 24h ago and it worked fine. Maybe this thread isn't the right place to post this in, I guess it could be an unrelated problem.

[Laurent]

You're right, this was a stupid error related to this modification today. Now it should work.

Thanks for your quick feedback

[Oz1571]

Haha, thanks for the quick fix. It does indeed work fine again.

[panithadrum]

The shader example has one error: the global shader mousey parameters seems to be working like 1-mouseY.

If you replace the update code like this, it works.

Code: [Select]

// Update the shaders
backgroundShader.Update(mouseX, mouseY);
entityShader.Update(mouseX, mouseY);
globalShader.Update(mouseX, 1-mouseY);

[Laurent]

It fixes only the "fisheye" effect, all other effects get broken.

This is not really an error, actually the fisheye effect should be more complex in order to handle properly the texture coordinates.

[panithadrum]

I thought the problem wasn't fisheye, but globalShader

Is it because you are using a RenderImage?