collision detection

[lack]

Hi, when i run my program, the controllable rectangle is always blue although i want it to be red when it collides with tiles with the value 1.

 player.Update();
    for(int i = 0; i < colMap.size(); i++)
{
        for(int j = 0; j < colMap[i].size(); j++)
        {
            if(colMap[i][j] == 1)
            {
            int bottom, top, left, right;
            bottom = i * 40 + 40;
            top = i * 40;
            right = j * 40 + 40;
            left = j * 40;

                if(player.right < left || player.left > right || player.top > bottom || player.bottom < top)
                {
                    player.rect.setFillColor(sf::Color::Blue);
                }
                else
                {
                    player.rect.setFillColor(sf::Color::Red);
                    break;
                }
            }

        }
}

Stuff that might help you further:

(click to show/hide)

main.cpp

 #include <SFML/Graphics.hpp>
#include <iostream>
#include <string>
#include <tilemap.h>
#include <vector>
#include <sstream>
#include <sstream>
#include <cctype>
#include <fstream>
#include <class.h>
using namespace std;

vector<vector<int> > colMap;
void LoadColMap(const char*filename)
{
    ifstream openfile(filename);
    vector<int> tempMap;
    colMap.clear();
    if(openfile.is_open())
    {
        while(!openfile.eof())
        {
            string str, value;
            getline(openfile, str);
            stringstream stream(str);

            while(getline(stream, value, ' '))
            {
                  if(value.length() > 0)
                    {
                        int a = atoi(value.c_str());
                        tempMap.push_back(a);
                    }
            }
            colMap.push_back(tempMap);
            tempMap.clear();
        }
    }
}
int world() {
    //character position
    enum Direction{ Down, Left, Right, Up };
    sf::Vector2i source(1, Down);
    sf::RenderWindow window2(sf::VideoMode(640,640), "Game");
    window2.setKeyRepeatEnabled(true);
    Player player(sf::Vector2f(40, 40), sf::Vector2f(40, 40), sf::Color::Green);
    player.rect.setFillColor(sf::Color::Green);
    LoadColMap("lel.txt");
    player.Update();
    for(int i = 0; i < colMap.size(); i++)
{
        for(int j = 0; j < colMap[i].size(); j++)
        {
            if(colMap[i][j] == 1)
            {
            int bottom, top, left, right;
            bottom = i * 40 + 40;
            top = i * 40;
            right = j * 40 + 40;
            left = j * 40;

                if(player.right < left || player.left > right || player.top > bottom || player.bottom < top)
                {
                    player.rect.setFillColor(sf::Color::Blue);
                }
                else
                {
                    player.rect.setFillColor(sf::Color::Red);
                    break;
                }
            }

        }
}
    /*window2.clear(sf::Color(0, 240, 255));

    for(int i = 0; i < map.size(); i++)
    {
        for(int j = 0; j < map[i].size(); j++)
        {
            if(map[i][j].x != -1 && map[i][j].y != -1)
            {
                tiles.setPosition(j * 40, i * 40);
                tiles.setTextureRect(sf::IntRect(map[i][j].x * 32, map[i][j].y * 32, 32, 32));
                window.draw(tiles);
            }
        }
    }*/
    const int level[] =
    {
        1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
        1, 0, 1, 1, 1, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 1,
        1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0, 1,
        1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 1, 0, 1,
        1, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 0, 1,
        1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 1,
        1, 0, 1, 0, 1, 0, 1, 0, 1, 1, 1, 1, 0, 1, 0, 1,
        1, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 0, 0, 1, 0, 1,
        1, 0, 1, 0, 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 1,
        1, 0, 1, 1, 1, 1, 1, 0, 1, 0, 0, 1, 0, 1, 0, 1,
        1, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 0, 1,
        1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 1, 0, 1, 0, 1,
        1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 1, 0, 1, 0, 1,
        1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 1, 1, 1, 0, 1,
        1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1,
        1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
    };
     /*for (int y = quad[0].position; y <= quad[1].position; ++y)
    {
        for (int x = quad[2].position; x <= quad[3].position; ++x)
        {
            // Entity is touching tile[x, y] so check and handle collision
        }
    } */
    // create the tilemap from the level definition
    TileMap map;
    if (!map.load("tileset.png", sf::Vector2u(40, 40), level, 16, 16))
        return -1;

    sf::Texture char1texture;
    if(!char1texture.loadFromFile("char1.jpg")) {
        cout << "error" << endl;
        }
    sf::Sprite char1sprite;
    char1sprite.setPosition(sf::Vector2f(40, 40));
    char1sprite.setTexture(char1texture);
    sf::Vector2f position = char1sprite.getPosition();
    while(window2.isOpen()) {
        sf::Event event;
        while(window2.pollEvent (event)) {
            switch(event.type) {
                case sf::Event::Closed:
                    window2.close();
                    break;
                case sf::Event::KeyPressed:
                    if(event.key.code == sf::Keyboard::Up) {
                        cout << "Your character moved up" << endl;
                        source.y = Up;
                        player.rect.move(0, -40);
                        break; }
                    else if(event.key.code == sf::Keyboard::Down) {
                        cout << "Your character moved down" << endl;
                        source.y = Up;
                        player.rect.move(0, 40);
                        break;
                    }
                    else if(event.key.code == sf::Keyboard::Right) {
                        cout << "Your character moved right" << endl;
                        source.y = Up;
                        player.rect.move(40, 0);
                        break;
                    }
                    else if(event.key.code == sf::Keyboard::Left) {
                        cout << "Your character moved left" << endl;
                        source.y = Up;
                        player.rect.move(-40, 0);
                        break;
                    }
                default: {
                    break;
                    }
            }
        }
        window2.clear(sf::Color::Black);
        window2.draw(map);
        window2.draw(player.rect);
        window2.display();
    }
}

int main() {
    sf::RenderWindow window(sf::VideoMode(800,600), "Game");
    sf::Texture bgtexture;
    if(!bgtexture.loadFromFile("bgtexture.jpg")) {
        cout << "error" << endl;
        }
    sf::Sprite bgsprite;
    bgsprite.setTexture(bgtexture);
    sf::Texture sgtexture;
    if(!sgtexture.loadFromFile("sgtexture.jpg")) {
        cout << "error" << endl;
        }
    sf::Sprite sgsprite;
    sgsprite.setTexture(sgtexture);
    sgsprite.setPosition(250, 150);
    sf::Texture sgtexture2;
    if(!sgtexture2.loadFromFile("sgtexture2.jpg")) {
        cout << "error" << endl;
        }
    sf::Sprite sgsprite2;
    sgsprite2.setTexture(sgtexture2);
    sgsprite2.setPosition(250, 250);
    while(window.isOpen()) {
        sf::Event event;
        while(window.pollEvent (event)) {
            switch(event.type) {
                case sf::Event::Closed:
                    window.close();
                    break;
                case sf::Event::MouseButtonPressed:
                    if (event.mouseButton.button == sf::Mouse::Left)
                        {
                            if(sgsprite2.getGlobalBounds().contains(event.mouseButton.x, event.mouseButton.y)) {
                                window.close();
                                break;
                            }
                            else if(sgsprite.getGlobalBounds().contains(event.mouseButton.x, event.mouseButton.y)) {
                                window.close();
                                world();
                                break;
                            }
                        }
                default: {
                    break;
                    }
            }
        }
        window.clear(sf::Color::Black);
        window.draw(bgsprite);
        window.draw(sgsprite);
        window.draw(sgsprite2);
        window.display();
    }
    return 0;
}
 

(click to show/hide)

class.h

 #ifndef CLASS_H
#define CLASS_H
#include <SFML/Graphics.hpp>


class Player {
public:
    sf::RectangleShape rect;
    float bottom, left, right, top;
    Player(sf::Vector2f position, sf::Vector2f size, sf::Color color)
    {
        rect.setPosition(position);
        rect.setSize(size);
        rect.setFillColor(color);
    }

    void Update()
    {
        bottom = rect.getPosition().y + rect.getSize().y;
        left = rect.getPosition().x;
        right = rect.getPosition().x + rect.getSize().x;
        top = rect.getPosition().y;
    }

};

(click to show/hide)

tilemap.h

 #ifndef TILEMAP_H
#define TILEMAP_H
#include <SFML/Graphics.hpp>


class TileMap : public sf::Drawable, public sf::Transformable
{
public:

    bool load(const std::string& tileset, sf::Vector2u tileSize, const int* tiles, unsigned int width, unsigned int height)
    {
        // load the tileset texture
        if (!m_tileset.loadFromFile(tileset))
            return false;

        // resize the vertex array to fit the level size
        m_vertices.setPrimitiveType(sf::Quads);
        m_vertices.resize(width * height * 4);

        // populate the vertex array, with one quad per tile
        for (unsigned int i = 0; i < width; ++i)
            for (unsigned int j = 0; j < height; ++j)
            {
                // get the current tile number
                int tileNumber = tiles[i + j * width];

                // find its position in the tileset texture
                int tu = tileNumber % (m_tileset.getSize().x / tileSize.x);
                int tv = tileNumber / (m_tileset.getSize().x / tileSize.x);

                // get a pointer to the current tile's quad
                sf::Vertex* quad = &m_vertices[(i + j * width) * 4];

                // define its 4 corners
                quad[0].position = sf::Vector2f(i * tileSize.x, j * tileSize.y);
                quad[1].position = sf::Vector2f((i + 1) * tileSize.x, j * tileSize.y);
                quad[2].position = sf::Vector2f((i + 1) * tileSize.x, (j + 1) * tileSize.y);
                quad[3].position = sf::Vector2f(i * tileSize.x, (j + 1) * tileSize.y);

                // define its 4 texture coordinates
                quad[0].texCoords = sf::Vector2f(tu * tileSize.x, tv * tileSize.y);
                quad[1].texCoords = sf::Vector2f((tu + 1) * tileSize.x, tv * tileSize.y);
                quad[2].texCoords = sf::Vector2f((tu + 1) * tileSize.x, (tv + 1) * tileSize.y);
                quad[3].texCoords = sf::Vector2f(tu * tileSize.x, (tv + 1) * tileSize.y);
            }

        return true;
    }

private:

    virtual void draw(sf::RenderTarget& target, sf::RenderStates states) const
    {
        // apply the transform
        states.transform *= getTransform();

        // apply the tileset texture
        states.texture = &m_tileset;

        // draw the vertex array
        target.draw(m_vertices, states);
    }

    sf::VertexArray m_vertices;
    sf::Texture m_tileset;
};

(click to show/hide)

tilemap and collisionmap
1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
1 0 1 1 1 0 1 0 0 0 0 0 0 1 0 1
1 0 0 0 1 0 0 0 1 1 1 1 1 1 0 1
1 0 1 0 1 0 1 0 1 0 1 0 0 1 0 1
1 0 1 0 1 1 1 0 0 0 1 0 1 1 0 1
1 0 1 0 1 0 0 0 1 0 0 0 0 1 0 1
1 0 1 0 1 0 1 0 1 1 1 1 0 1 0 1
1 0 1 0 1 1 1 0 0 0 0 0 0 1 0 1
1 0 1 0 0 0 1 0 1 1 0 1 0 1 0 1
1 0 1 1 1 1 1 0 1 0 0 1 0 1 0 1
1 0 0 0 0 0 0 0 1 1 0 1 0 1 0 1
1 0 1 1 1 0 1 1 1 1 0 1 0 1 0 1
1 0 1 0 1 0 1 0 1 0 0 1 0 1 0 1
1 0 1 0 1 0 1 0 1 0 1 1 1 1 0 1
1 0 0 0 1 0 0 0 1 0 0 0 0 0 0 1
1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

thanks

[DarkRoku12]

You can use the built-in sf::Rect<type>::intersect( sf::Rect<type> )

See the docs:

http://www.sfml-dev.org/documentation/2.0/classsf_1_1Rect.php#a566740c8f58e01bb052266f47e7e1011

This is a good tutorial for general collision detection:

http://www.toptal.com/game/video-game-physics-part-ii-collision-detection-for-solid-objects

[lefreut]

Hello,

The break statement in C++ will break out of the for statement in which the break is directly placed. In your sample, the outer loop will continue and your code will reset the color to blue.

[lack]

oh thanks for the notice, i fixed it but the problem seems to persist, any other clues?
I do get the idea behind collision detection but trying to do it with an array is difficult for me

[lack]

Fixed it, forgot to put the player updating function under the active event poll, too much coffee isn't good for my health