[Solved] Failed to load image from memory, no data provided

[tyrbo321]

I'm using SFML with C++ in VS2012. In debug console i have error "failed to load image from memory, no data provided".



My main.cpp

#include <iostream>
#include "Test.h"
#include "resource.h"
#include <SFML/System.hpp>
#include <SFML/Window.hpp>
#include <SFML/Graphics.hpp>
#include <SFML/Audio.hpp>

using namespace std;

sf::Image LoadImageFromResource(const std::string& name)
{
    HRSRC rsrcData = FindResource(NULL, name.c_str(), RT_RCDATA);

    DWORD rsrcDataSize = SizeofResource(NULL, rsrcData);

    HGLOBAL grsrcData = LoadResource(NULL, rsrcData);

    LPVOID firstByte = LockResource(grsrcData);


    sf::Image image;
    image.loadFromMemory(firstByte, rsrcDataSize);


    return image;
}

int main()
{      
    sf::Image SpriteSheetWalkRes = LoadImageFromResource("IDB_PNG1");
}

My Resource.rc

#define APSTUDIO_READONLY_SYMBOLS

#include "afxres.h"

#undef APSTUDIO_READONLY_SYMBOLS

#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_RUS)
LANGUAGE LANG_RUSSIAN, SUBLANG_DEFAULT

#ifdef APSTUDIO_INVOKED

1 TEXTINCLUDE
BEGIN
    "resource.h\0"
END

2 TEXTINCLUDE
BEGIN
    "#include ""afxres.h""\r\n"
    "\0"
END

3 TEXTINCLUDE
BEGIN
    "\r\n"
    "\0"
END

#endif

IDB_PNG1            RCDATA           "F:\\(...)\\test_player.png"

#endif

#ifndef APSTUDIO_INVOKED

#endif

 

My resource.h

#define IDB_PNG1                        101

#ifdef APSTUDIO_INVOKED
#ifndef APSTUDIO_READONLY_SYMBOLS
#define _APS_NEXT_RESOURCE_VALUE        102
#define _APS_NEXT_COMMAND_VALUE         40001
#define _APS_NEXT_CONTROL_VALUE         1001
#define _APS_NEXT_SYMED_VALUE           101
#endif
#endif

[eXpl0it3r]

Since this is the direct result of the following statement failing, it means that either your size or your pointer is 0.

if (data && dataSize)

It's always a good advice to run your code in a debugger and/or printing the variables out, to verify their content.

[tyrbo321]

Since this is the direct result of the following statement failing, it means that either your size or your pointer is 0.

if (data && dataSize)

It's always a good advice to run your code in a debugger and/or printing the variables out, to verify their content.

Also im trying use bitmap for load, like in original sample, and again this error, i think i have wrong code.

[eXpl0it3r]

As mentioned, start the debugger and check your variables.

[tyrbo321]

This method works for you, have you ever used it?
If you can, please, make project with that system, and add any resource (just image) on sfml, and give link me, it will be easier to understand the issue. Maybe i have wrong project settings.

[eXpl0it3r]

loadFromMemory works fine if you pass it the correct data. As I said before either your rsrcDataSize or your firstByte is zero thus it doesn't work. The problem is in the resource loading part, i.e. your own code. Thus debug it and/or read the docs again on how to use it.
Personally I've never used the Windows resource system to load things, so no idea how it works.

[Hapax]

Are you sure that

IDB_PNG1            RCDATA           "F:\\(...)\\test_player.png"

is correct?
Wouldn't this just take the literal path string as the raw data stored in the resource?

RCDATA

[tyrbo321]

Crap... No resource problem and no file path problem, just dont want load any image from resources. I need working project to know issue.

[Hapax]

I don't fully understand what you mean. Did that help?

just dont want load any image from resources.

If your goal is to avoid having separate files, you can link them into your executable without using Microsoft's resources. A simple way is to convert the binary file into a header file - with an array of the data - that can be linked into your project and built into your executable. This has the added benefit that it also allows your project to be cross-platform.

If you would prefer to continue with Microsoft's resource manager, you may find what you need here:
ICON resource
BITMAP resource

[tyrbo321]

I don't fully understand what you mean. Did that help?

just dont want load any image from resources.

If your goal is to avoid having separate files, you can link them into your executable without using Microsoft's resources. A simple way is to convert the binary file into a header file - with an array of the data - that can be linked into your project and built into your executable. This has the added benefit that it also allows your project to be cross-platform.

If you would prefer to continue with Microsoft's resource manager, you may find what you need here:
ICON resource
BITMAP resource

Thx man, i read about converting the binary file into a header file, and i convert my png to .h now, but i cant find examples, and manuals how open it as image. I include .h now, ok, but as i try load it as image it does not work (not surprising). Maybe my question stupid, but how?

[Jesper Juhl]

Maybe if you provided a Short, Self Contained, Correct (Compilable), Example people would be able to help you better...
Right now my impression is that SFML works just fine (especially given that I've personally used these bits of the API with no trouble) and that the bug must be in your code.
Provide a complete example (see link above) and then we'll all have a much better base to talk about.

[Hapax]

i convert my png to .h now, but i cant find examples, and manuals how open it as image. I include .h now, ok, but as i try load it as image it does not work (not surprising). Maybe my question stupid, but how?

There has been talks of this on the forum before but I can't remember where.

Here's a simple example of how to load an image file from a header into an sf::Image:

#include <SFML/Graphics.hpp>
#include "icon_png.hpp"
int main()
{
    sf::Image image;
    image.loadFromMemory(sfmlIconPngData, 3104); // exact size of array

    sf::RenderWindow window(sf::VideoMode(300, 16), "Include Image File As Header", sf::Style::Default);
    sf::Texture texture;
    texture.loadFromImage(image);
    sf::Sprite sprite(texture);
    while (window.isOpen())
    {
        sf::Event event;
        while (window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
                window.close();
        }
        window.clear();
        window.draw(sprite);
        window.display();
    }
    return EXIT_SUCCESS;
}

The header (icon_png.hpp) is attached.

[tyrbo321]

i convert my png to .h now, but i cant find examples, and manuals how open it as image. I include .h now, ok, but as i try load it as image it does not work (not surprising). Maybe my question stupid, but how?

There has been talks of this on the forum before but I can't remember where.

Here's a simple example of how to load an image file from a header into an sf::Image:

#include <SFML/Graphics.hpp>
#include "icon_png.hpp"
int main()
{
    sf::Image image;
    image.loadFromMemory(sfmlIconPngData, 3104); // exact size of array

    sf::RenderWindow window(sf::VideoMode(300, 16), "Include Image File As Header", sf::Style::Default);
    sf::Texture texture;
    texture.loadFromImage(image);
    sf::Sprite sprite(texture);
    while (window.isOpen())
    {
        sf::Event event;
        while (window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
                window.close();
        }
        window.clear();
        window.draw(sprite);
        window.display();
    }
    return EXIT_SUCCESS;
}

The header (icon_png.hpp) is attached.

Thx man, without you I would not have solved the problem

[Hapax]

You're very welcome.
Which part helped you, if you don't mind me asking?

[tyrbo321]

You're very welcome.
Which part helped you, if you don't mind me asking?

This part.

image.loadFromMemory(sfmlIconPngData, 3104);

I don't wrote exact size of array, and tried to load as an image using loadFromFile.