Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: Add a bookmark icon  (Read 4970 times)

0 Members and 1 Guest are viewing this topic.

JPB515

  • Newbie
  • *
  • Posts: 6
    • View Profile
Add a bookmark icon
« on: June 06, 2016, 01:09:33 am »
Hi,

I've just started using SFML for a project and I'm finding my iPad a really useful tool for reading the documentation whilst I'm working. The problem is that adding the website to my home screen is causing a really ugly snapshot of the page to be used as an icon, when the SFML logo almost seems designed for a square icon. Since this could be done with a couple of lines of HTML and an image, could an icon please be added to the documentation home page for those of us who like to work in this way.

Thanks in advance!

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32504
    • View Profile
    • SFML's website
    • Email
Re: Add a bookmark icon
« Reply #1 on: June 06, 2016, 06:22:19 am »
Quote
Since this could be done with a couple of lines of HTML and an image
Would you mind sharing the solution with us?

I'm not an expert but I have no idea what could be done, since the website already has a favicon and I thought it would be the one chosen when you do this kind of things.
Laurent Gomila - SFML developer

eXpl0it3r

  • SFML Team
  • Hero Member
  • *****
  • Posts: 10323
    • View Profile
    • development blog
    • Email
Re: Add a bookmark icon
« Reply #2 on: June 06, 2016, 01:36:54 pm »
Not sure how I can properly test this, but I think this PR should add the icons.
Official FAQ: https://www.sfml-dev.org/faq.php
Official Discord Server: https://discord.gg/nr4X7Fh
——————————————————————
Dev Blog: https://dev.my-gate.net/

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32504
    • View Profile
    • SFML's website
    • Email
Re: Add a bookmark icon
« Reply #3 on: June 06, 2016, 02:10:00 pm »
Too bad it has to be so ugly for such a specific feature... :-\
Laurent Gomila - SFML developer

eXpl0it3r

  • SFML Team
  • Hero Member
  • *****
  • Posts: 10323
    • View Profile
    • development blog
    • Email
Re: Add a bookmark icon
« Reply #4 on: June 07, 2016, 12:31:54 pm »
After some more research (sheesh Apple, couldn't you have made it a bit more simple?!), I figured we could go the lazy way (see the PR).
Official FAQ: https://www.sfml-dev.org/faq.php
Official Discord Server: https://discord.gg/nr4X7Fh
——————————————————————
Dev Blog: https://dev.my-gate.net/

JPB515

  • Newbie
  • *
  • Posts: 6
    • View Profile
Re: Add a bookmark icon
« Reply #5 on: June 11, 2016, 02:58:06 am »
Would you mind sharing the solution with us?

Sorry not to reply before now. Apple has an article about how to do this here. The PR is right about the icon but adding the HTML to the specific pages adds flexibility if further down the line there were to be different icons for, say, the tutorials, documentation and forum...

I don't know that this can actually be tested without pushing the icon to the live site. Maybe if the website were zipped and sent to an iOS device but that seems like a disproportionately huge undertaking to test such a small feature.

Thanks for your efforts looking into this.

eXpl0it3r

  • SFML Team
  • Hero Member
  • *****
  • Posts: 10323
    • View Profile
    • development blog
    • Email
Re: Add a bookmark icon
« Reply #6 on: July 09, 2016, 09:40:45 am »
JPB515 I've pushed the changes. Could you test if the icon shows?
Official FAQ: https://www.sfml-dev.org/faq.php
Official Discord Server: https://discord.gg/nr4X7Fh
——————————————————————
Dev Blog: https://dev.my-gate.net/

dabbertorres

  • Hero Member
  • *****
  • Posts: 506
    • View Profile
    • website/blog
Re: Add a bookmark icon
« Reply #7 on: July 09, 2016, 11:38:14 am »
If more work needs doing, I recently found out about a favicon generator site (supporting everything under the sun) that might help.

 

anything