[IDEA] Move sf::Rect into System Module?

[coolhome]

Hello SFML Community!

I was looking over the library and every time I use sf::Rect I always include the system module. However I always forget its in the Graphics Module. Wouldn't it make more sense to put it in the systems module? Just an idea. Nothing to important. Just in my opinion I think it would have a better home in the system module.

-coolhome

[Laurent]

sf::Rect is a graphical class, I don't know why the system module would be a better home for it

[Walker]

How is it a graphical class? I can't render one  :lol:

I tend to use sf::Rect mostly for collision detection.

It seems like it could fit alongside the Vector classes in System quite well but I do see why it is in the Graphics module in the first place.

[Mr. X]

I think, sf::Rect is similar to sf::Vector2 and sf::Vector3, which belong to sfml-system. They are all classes which can not be rendered and consist of numbers to be used for calculations. Thus I agree to coolhome and Walker that it should be moved to sfml-system. If you think, sf::Rect should be in sfml-graphics, then sf::Vector2/3 should be in sfml-graphics as well.

[Groogy]

The thing is for SFML the sf::Rect class is only used in the graphics module while Vector2 and Vector3 is used in a lot of other modules besides graphics.

[Laurent]

I wish Vector2 could be in sfml-graphics but Vector3 is used in sfml-audio so it's more consistent to have them grouped in sfml-system.

Rect cannot be rendered but it stores 2D coordinates, which makes no sense in windowing/networking/audio. That's why I said it's a graphical class.

[Haikarainen]

I agree with coolhome, it really doesn't have to be a graphical class, even though it currently only is used for that. A more appropriate  place for it would be the systemlibrary indeed.

It basically just is a 2d vector with 2 extra parameters to define the dimensionsize, and is often used for more than pure graphics. At least thats how i see it.

[Nexus]

Rect cannot be rendered but it stores 2D coordinates, which makes no sense in windowing/networking/audio. That's why I said it's a graphical class.

At least the Window module also uses sf::Rect (for the viewport). Do you find it okay that Window depends on Graphics?

The System module might indeed be a better place for sf::Rect. It also preserves you the freedom to use it somewhere else one day, without breaking the user's include paths.

[Laurent]

At least the Window module also uses sf::Rect (for the viewport). Do you find it okay that Window depends on Graphics?

Window doesn't depend on Graphics, and doesn't use sf::Rect.

[Nexus]

Ah, sorry. I thought sf::View would be in the Window module, since sf::Window is. I wasn't aware that GetView() is only introduced in sf::RenderWindow, but it makes sense.

Nevertheless, the second paragraph still applies

[Laurent]

Yeah... I admit that it's not a bad idea.

... Maybe :lol:

[coolhome]

Yeah... I admit that it's not a bad idea.

... Maybe :lol:

At least he is slightly considering it

[Disch]

I understand Laurent's hesitation.  It isn't as cut and dry as it may seem.

Sure Rect might seem strange in the Graphics module.  But really, when you think about it, is it any less strange than the System module?  What does Rect have to do with the system?  At least in the Graphics module it has applications.

To me, the real question is, how are these modules defined?  I get the impression that people here have the idea that the System module is sort of like a catch-all for the classes that don't fit anywhere else.  But is that really the intent?

Perhaps a solution here is to introduce another module for one-off classes that don't fit anywhere else, like the Vectors, Rect, etc.  But that's probably more trouble than it's worth.

[Tank]

I understand "sfml-system" as being a sub-library both for system and core things.

I agree that sf::Rect would be better placed in sfml-system. Sure, it's mostly used for graphics, but it's really an absolute core feature that can be used without using the graphics library at all, which I currently *have to* use, just for a plain rect structure.

I always accidently write "#include <SFML/System/Rect.hpp>" before I fix it to ".../Graphics/...".

(note to myself: I should not start every line with "I")

[omeg]

Another thing to keep in mind is that for example in SFML.Net there is no System library since it's not needed, all its functionality is in base class library anyway.