Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: I've made a pull request on Github that I hope you'll consider.  (Read 2166 times)

0 Members and 1 Guest are viewing this topic.

cuddlyogre

  • Newbie
  • *
  • Posts: 10
    • View Profile
I've made a pull request on Github that I hope you'll consider.
« on: November 17, 2013, 08:32:48 am »
https://github.com/SFML/SFML.Net/pull/26

I've implemented Equals, GetHashCode, and Vector2.zero.

Equals allows you to check if one Vector2's value is the same as another's.
GetHashCode lets it be used in a dictionary effectively.
Zero returns a Vector2 with its X and Y set to 0.

I come from an XNA background, and I really missed the Vector2.Zero property since it is surprisingly helpful, most especially for uniform sprite movement.

I admittedly am not familiar with Git enough to know how to make a request for only the one request, so feel free to ignore the project related requests.

The intended commit is 1540bb0566f3b2e613b8c31c392b368351ddf2f4

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32504
    • View Profile
    • SFML's website
    • Email
Re: I've made a pull request on Github that I hope you'll consider.
« Reply #1 on: November 17, 2013, 10:11:02 am »
No need to post on the forum too, I actually read pull requests.
Laurent Gomila - SFML developer

cuddlyogre

  • Newbie
  • *
  • Posts: 10
    • View Profile
Re: I've made a pull request on Github that I hope you'll consider.
« Reply #2 on: November 17, 2013, 11:21:37 am »
Very good. I appreciate the attentiveness to have towards this project.

 

anything