Restricting Sprite Movement in Loop

[GarryS]

I am using SFML 2.0...

I am confident that there is a better way but I have been banging my head on the wall for hours here.  

Basically, I have a character (sprite) that needs to move in an array but only 1 time per key press.  The code shows up and down "movement".  Left and Right would need to be additionally coded.

Here is what I have cobbled together but I know that this can't be "right":

Code: [Select]



bool keyUp = false;
bool keyDown = false;

while (window.IsOpened()) {
  while (window.PollEvent(event)) {
    if ((keyUp == false)&& sf::Keyboard::IsKeyPressed(sf::Keyboard::Up))) {
      keyUp = true;
      moveHero(dave.location,dave.location = dave.location -= X_TILES);
    }
    if ((keyUp == true)&&(!sf::Keyboard::IsKeyPressed(sf::Keyboard::Up)))
        keyUp = false;
      if ((keyDown == false)&&(sf::Keyboard::IsKeyPressed(sf::Keyboard::Down))) {
          keyDown = true;
          moveHero(dave.location,dave.location = dave.location += X_TILES);
      }
      if ((keyDown == true)&&(!sf::Keyboard::IsKeyPressed(sf::Keyboard::Down)))
          keyDown = false;
    }
  }
}


Anyone have a moment to help a noob out?

Thanks

[GarryS]

This seems to be a much better way to accomplish what I was attempting.

Code: [Select]


   while (window.PollEvent(event)) {
      processEvents(window, event);
      switch (event.Type) {
        case sf::Event::KeyReleased:
        if (event.Key.Code == sf::Keyboard::Up) {
          moveHero(dave.location,dave.location = dave.location -= X_TILES);
          break;
        }
        if (event.Key.Code == sf::Keyboard::Down) {
          moveHero(dave.location,dave.location = dave.location += X_TILES);
          break;
        }
        if (event.Key.Code == sf::Keyboard::Left) {
          moveHero(dave.location,dave.location = dave.location -= 1);
          break;
        }
        if (event.Key.Code == sf::Keyboard::Right) {
          moveHero(dave.location,dave.location = dave.location += 1);
          break;
        }
        default:
        break;
      }
    }


Thanks

[Lee R]

Code: [Select]


moveHero(dave.location,dave.location = dave.location -= X_TILES);


Don't do that. The C++ standards does not specify the order of evaluation for function arguments.

[GarryS]

Code: [Select]


moveHero(dave.location,dave.location = dave.location -= X_TILES);


Don't do that. The C++ standards does not specify the order of evaluation for function arguments.

Thanks for the info.  Fixing that now!