sf::Transform::Combine() result

[Nexus]

The function sf::Transform::Combine() is a little bit misleading in my opinion. It makes the impression as if the result is stored in *this, and not returned as an independent copy. Additionally, the documentation for Translate() says "Combine the current transform with a translation", where the term "combine" is used with semantics different from the Combine() method.

Other functions returning copies like GetInverse() are also named differently, maybe GetCombination()/GetCombined() would be more intuitive. Or you only provide Combine() which changes *this. Or a global function. Or you don't provide it at all, as the same functionality is already covered by operator* and operator*=.

I don't know what other users think about this, maybe I'm the only one. It was just something that took my attention.

[Laurent]

To be honest it caught my attention too, this week, when writing the .Net binding of sf::Transform.

Making Combine() modify *this would be consistent with other functions, so it seems to be the best solution to me. What do you think?

[Nexus]

Yes, I also like this solution.

Out of interest, do you provide Combine() in addition to the multiplication operator for expressivity?

[Laurent]

Yes. Providing only operators is ok for trivial stuff like addition between two vectors (nobody would ever use a Vector::Add function), but for transforms, where multiplication may not be clear for everyone, I think it's better to have a named equivalent.