Color::makeColorHSV(int hue, float sat, float val)

[Tenry]

What about an hsv color function? It could be very useful to generate random colors with a certain saturation and value, or fading from one color (hue) to another.

// hue: 0-360°; sat: 0.f-1.f; val: 0.f-1.f
sf::Color hsv(int hue, float sat, float val)
{
  hue %= 360;
  while(hue<0) hue += 360;

  if(sat<0.f) sat = 0.f;
  if(sat>1.f) sat = 1.f;

  if(val<0.f) val = 0.f;
  if(val>1.f) val = 1.f;

  int h = hue/60;
  float f = float(hue)/60-h;
  float p = val*(1.f-sat);
  float q = val*(1.f-sat*f);
  float t = val*(1.f-sat*(1-f));

  switch(h)
  {
    default:
    case 0:
    case 6: return sf::Color(val*255, t*255, p*255);
    case 1: return sf::Color(q*255, val*255, p*255);
    case 2: return sf::Color(p*255, val*255, t*255);
    case 3: return sf::Color(p*255, q*255, val*255);
    case 4: return sf::Color(t*255, p*255, val*255);
    case 5: return sf::Color(val*255, p*255, q*255);
  }
}

[Laurent]

I think it has already been discussed.

I have no strong argument against it, it's just that I don't want to add such features now

[Tenry]

I think it has already been discussed.

I have no strong argument against it, it's just that I don't want to add such features now

Hm, I have searched for "hsv" before without any results :/

Such a method could be easily implemented, there's already the code above. And I would do it as a static method returning an sf::Color.

But I hope you'll add such feature soon

[Haikarainen]

Well SFML is a multimedia library, HSV support should really, really be implemented if you think about it. I like how Visual Studio stuff have this kinda helpers with it. I see huge potential in it and it has my vote!

[Lupinius]

HSV is crucial when you try do to any random color creation. My solutions always end up being messy and I'd like a native way of doing this as well.

[Laurent]

Well, this is a minor issue, given that anyone can add this very simple function to his own code.

[Nexus]

Code: [Select]

// hue: 0-360°; sat: 0.f-1.f; val: 0.f-1.f You could also check those preconditions with assert. Using if, you are only wasting time, because in most cases, the passed values are correct anyway. Otherwise, the caller can still use modulo, std::min() or std::max() and pass the right values directly. The other advantage is that assert is able to catch logic errors instead of "justifying" them.