Getting a "Failed to load image" error, not sure how to fix it.

[gws923]

Hello all.  I have a program that contains a list of "points" (which are just what they sound like).  These points are represented on screen by a point.png.

If I have a lot of points on the screen (50+?)  the program eventually crashes, even without user input, and displays the follow error message several times, though NOT as many times as there are points.

Failed to load image "images/point.png". Reason: Corrupt JPEG
Image /images/point.png failed to load.

Now, first of all, it ain't a JPEG file, so how can it be corrupt?  Also, if I change the image path to point.jpg, it STILL gives me this same error message.  I don't use point.png anywhere else in my code.

Can anyone help me make sense of this error message and how I can address it?

[Perde]

and displays the follow error message several times, though NOT as many times as there are points

By saying that, do you mean that you're loading the same file several times?

[edit]
Someone else might know what your problem is without, but it might help to show how you're loading the image and how you're displaying it.

[aBallofWin]

Are you loading a new image for each point you have, or are you just loading the image once then assigning it to points?

[gws923]

By saying that, do you mean that you're loading the same file several times?

I suppose I am loading the same image several times, which now that I think of it, is a stupid idea, huh?  I'll try and rework it to only load once and let you all know if it fixes it (I'm sure it will).

Thanks, everyone!

[gws923]

Ok, so I've tried to rework it but I'm still having trouble.  I have a pointmanager to manage all my points, and here is its constructor and then the method by which it should be assigning each point a texture.

PointManager::PointManager()
{
    currentId = 0;
    numLoopPoints = 0;
    numLoops = 0;

    if(!p1Texture.loadFromFile("images/point.png"))
        std::cout << "Image /images/point.png failed to load." << std::endl;

    if(!lp1Texture.loadFromFile("images/loop1point.png"))
        std::cout << "Image /images/loop1point.png failed to load." << std::endl;

    if(!lp2Texture.loadFromFile("images/loop2point.png"))
        std::cout << "Image /images/loop2point.png failed to load." << std::endl;

}

void PointManager::AddPoint(Point * p1)
{
    //set IDs
    if(PointList.empty()){ p1->SetId(0);}
    else{p1->SetId(PointList.back().GetId() + 1);}

    //set Textures
    if(p1->GetType() == "edge"){p1->GetSprite().setTexture(p1Texture);}
    else if(p1->GetType() == "loop1"){p1->GetSprite().setTexture(lp1Texture);}
    else if(p1->GetType() == "loop2"){p1->GetSprite().setTexture(lp2Texture);}

    p1->GetSprite().setOrigin(2,2);
    p1->GetSprite().setPosition(p1->GetX(), p1->GetY());

    currentId = p1->GetId();
    PointList.push_back(*p1);
}
 

This compiles, but the points aren't showing up.  Any ideas?

EDIT: Got it working.  Apparently I had to pass the textures as pointers.

[eXpl0it3r]

This compiles, but the points aren't showing up.  Any ideas?

So it compiles and runs without spitting out errors?

Does GetSprite() return a reference or a copy? Because if it's a copy you will set the texture and the copy will get destroied as soon as you left the scope.

Do you get a white rectangle instead of the image?

[gws923]

Does GetSprite() return a reference or a copy? Because if it's a copy you will set the texture and the copy will get destroied as soon as you left the scope.

I think that was exactly the problem.  It was returning a copy.  I just wrote a SetTexture(sf::Texture *texture) method for Point.cpp that circumvented the problem.  Good to keep in mind.

[eXpl0it3r]

I highly suggest you should read something about references, const and smart pointers.

Raw pointers work fine as long as you handle them right, but seeing that you didn't really understand what happend there it's better to use safer methods.

[gws923]

Yeah, I'm still getting my feet wet with this stuff.  I wrote the GetSprite() function so long ago, though, that I guess it just didn't even occur to me to check it out.  I usually make sure to have my return types as pointers or references when it makes sense to do so, but I either wasn't thinking about it at the time, or it was so long ago I didn't know any better.  Thanks for your help!

[eXpl0it3r]

...return types as pointers or references..

I highly suggest you should read something about references, const and smart pointers.

Raw pointers work fine as long as you handle them right, but seeing that you didn't really understand what happend there it's better to use safer methods.

This although only applies if you want to write in a newer and safer way.