radeon: The kernel rejected CS, see dmesg for more information.

[mobai]

Hi!

I have a problem with the latest build of SFML2RC.

When I try to run

#include "IntroState.hpp"
#include <SFML/Graphics.hpp>
#include <iostream>

using namespace sf;
using namespace std;

IntroState::IntroState()
{
        splashTex = new Texture();
        splashTex->loadFromFile("splash.png");

        splash = new Sprite(*splashTex);
}

IntroState::~IntroState()
{
        delete splash;
        delete splashTex;
}

void IntroState::handleEvents(sf::RenderWindow *window)
{
        Event e;
        while(window->pollEvent(e))
        {
                if(e.type == Event::Closed)
                {
                        window->close();
                        cout << "closed" << endl;
                }
        }
}

void IntroState::draw(sf::RenderWindow *window)
{
        cout << "will now draw..." << endl;
        window->draw(*splash);
        cout << "drawn" << endl;

}

the created window looks weird and I get:

radeon: The kernel rejected CS, see dmesg for more information.

dmesg says:

[  507.205263] radeon 0000:01:05.0: alignments 832 1 1 1
[  507.205269] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
[  507.233217] radeon 0000:01:05.0: texture bo too small (800 600 26 0 -> 1920000 have 4096)

BUT:
When I put con- and destructor in draw(), like this:

void IntroState::draw(sf::RenderWindow *window)
{      
        splashTex = new Texture();
        splashTex->loadFromFile("splash.png");
        splash = new Sprite(*splashTex);
       
        cout << "will now draw..." << endl;
        window->draw(*splash);
        cout << "drawn" << endl;
       
        delete splash;
        delete splashTex;
}

it works!

I have no idea how to solve this problem. Maybe you have an idea?

If so, feel free to help.

greets, mobai

[Groogy]

Does the IntroState maybe get destroyed before the draw function is called?

Check what happens if you remove the delete from the state's destructor. Just to make sure that isn't the problem.

[mobai]

Sorry, but it looks like that's not the problem. It still doesn't work 

[Laurent]

We must see how your IntroState object is used. Could you please write a complete and minimal example that reproduces the problem?

[mobai]

the tar.lzma contains everything you need, incl. headers.

main.cpp:

#include "Game.hpp"
#include "IntroState.hpp"
#include <iostream>

using namespace std;

int main(int argc, char **argv)
{
        IntroState iSt;

        Game game(800, 600, "Test");
        game.changeState(&iSt);

        while(game.isOpen()){
                game.handleEvents();
                game.draw();
        }
}
 

Game.cpp:

#include "Game.hpp"
#include <SFML/Graphics.hpp>
#include <string>
#include <iostream>

using namespace std;

Game::Game(int x, int y, std::string label)
{
        window = new sf::RenderWindow(sf::VideoMode(x, y), label);
}


Game::~Game()
{
        delete window;
}

void Game::changeState(State *state)
{
        currentState = state;
}

void Game::handleEvents()
{
        currentState->handleEvents(window);
}

void Game::draw()
{
        window->clear();
        currentState->draw(window);
        window->display();
        cout << "displayed" << endl;
}

bool Game::isOpen()
{
        return window->isOpen();
}

IntroState.cpp:

#include "IntroState.hpp"
#include <SFML/Graphics.hpp>
#include <iostream>

using namespace sf;
using namespace std;

IntroState::IntroState()
{
        splashTex = new Texture();
        splashTex->loadFromFile("splash.png");

        splash = new Sprite(*splashTex);
}

IntroState::~IntroState()
{
        delete splash;
        delete splashTex;
}

void IntroState::handleEvents(sf::RenderWindow *window)
{
        Event e;
        while(window->pollEvent(e))
        {
                if(e.type == Event::Closed)
                {
                        window->close();
                        cout << "closed" << endl;
                }
        }
}

void IntroState::draw(sf::RenderWindow *window)
{
        cout << "will now draw..." << endl;
        window->draw(*splash);
        cout << "drawn" << endl;

}[code]

[attachment deleted by admin]

[Groogy]

With minimal he means one source file with only a main function. But this is small enough so I guess it works. It seems from the error message that it is having problems with the texture for the window. I guess the sprite isn't 800x600 right? Try increasing it's size to something a lot bigger and see what happens?

To me it looks like you are on Linux right? Try reinstalling the drivers and the mesa packages.

[mobai]

No, it's exactly 800x600. But I'll try it.

EDIT: 8000x6000 doesn't work

[Groogy]

Thaaat's way too big. I was thinking of like maybe: 1600x1200 or something like that.

[mobai]

Ok, this one is more minimal:
http://pastebin.com/0AhwCbqy

By the way: I tested the program on another PC (32-bit) and it didn't work.

[eXpl0it3r]

You could've also posted it here, instead of using pastebin...

I guess your problem is this bug, at least it fits perfectly your 'symptoms'.
Try to put the Game class initialization in front of the IntroState initialization.

Although you've only posted example code I'll still give you some hints on how to make it better.

• You're Game class gets instanciated to a unstable state, because the state member variable doesn't get initialized with NULL/nullptr. Thus if one would call handelEvents or draw without calling changeState before, the behavior would be undefined = crash. But that will also happen if it's set to nullptr, because you can't call a member function of a non-existing object, thus you'll need to check the existence before proceeding.
• Don't use pointers if it's not necessary, but use references and const references. (e.g. there's no reason for the RenderWindow to be allocated on the heap and managed with a pointer. Or there's no reason to pass the RenderWindow around as pointer instead of a reference.)
• It's adised to use smart pointers over normal pointers which will eliminate all 'delete' calls and with the factory functions make_shared() and make_unique() also all 'new' calls, which leads to a more stable and error proof code design.
• Make sure that all member variable get initialized!

[mobai]

OMG, eXpl0it3r, you're awesome. It  works. 

I tried not to use pointers and heap, but it didn't work (?).

Could you please give me an example of how to do it better?

EDIT:
ah, now I got it. The only pointer I have now is currentState

[eXpl0it3r]

OMG, eXpl0it3r, you're awesome. It  works. 

Glad I could help.

I tried not to use pointers and heap, but it didn't work (?).
Could you please give me an example of how to do it better?

What do you mean with "It didn't work"?

Anyways I've quickly made the changes to your code: http://pastebin.com/iHJhmf7E
I haven't tested it, but I guess it should work fine.

If you don't understand how references or initialization lists work, you should defently go back to your C++ book and reread those sections.

On my GitHub account I've also got a repository with a SmallGameEngine = state machine, that makes use of unique_ptr rather than raw pointers for managing states. The code could need a bit of a clean up but feel free to use whatever parts you want.

[FRex]

...go back to your C++ book...

Every time you say that I'm crying somewhere in the distance. 

that makes use of unique_ptr rather than raw pointers for managing states

Only in c++11 tho, in 03 there's a slightly different auto_ptr.

using namespace std;
using namespace sf;

Hope you're not doing that in actual code, this is not considered good practice.
Especially the first one, std has tons of things in it, some names might clash and it makes reading code a pain.

[eXpl0it3r]

Every time you say that I'm crying somewhere in the distance. 

Why?

[FRex]

I have no c++ book.