[FIXED] RenderTexture on Intel GPU's. Let's fix this problem!

[Ace (SWE)]

Had to register just to be able to say that the 1display branch solves the issue for me on my laptop, well done.

The shader example does seem to use the wrong shader for edge though.

[Haikarainen]

I'm not able to test this out today (probably), but I will certainly test it out when I have time!

I'll test both shaders and rendertextures

Great works, thanks szunti!

[Szunti]

I think the same intel_do_flush error will happen if you share context between screens regardless of my patch. Is it common to reuse context between screens? Is it allowed at all?

[Laurent]

SFML always uses the same screen (the default one).

[Haikarainen]

I think the same intel_do_flush error will happen if you share context between screens regardless of my patch. Is it common to reuse context between screens? Is it allowed at all?

1display-branch worked flawlessly with rendertextures! Will report back with shaders once I've tested them, but why would they be a problem?

EDIT: Have now tried it with both the minimal example I originally created, as well as a personal project of mine. And it totally works This is awesome!

[Haikarainen]

Allright I have thoroughly tested this branch, and it seems to do what it should perfectly. I have tried both RenderTextures and Shaders, as well as them both together (to "chainlink" shaders).

Also I might have misunderstood the shader issue, was it just an example that broke? Or the whole shader class?  It works flawlessly for me.

Laurent will this be merged anytime soon? I might be able to try it out on AMD hardware as well.

[Laurent]

Laurent will this be merged anytime soon?

I won't merge it directly because the code doesn't follow my conventions, but I'll try to do the modification soon (I'm starting right now).

[Haikarainen]

Laurent will this be merged anytime soon?

I won't merge it directly because the code doesn't follow my conventions, but I'll try to do the modification soon (I'm starting right now).

Great news Thanks a lot Laurent and Szunti!

[Szunti]

Also I might have misunderstood the shader issue, was it just an example that broke? Or the whole shader class?  It works flawlessly for me.

The shader example is one of the ones that gives the intel_do_flush_locked failed error. Now it runs at least with 1display branch, but the edge post-processing part is wrong because it uses the pixelate shader instead of the correct one, which can be seen with the software renderer.

It's the case for me, and I was curious if it happens for others too. But I guess it's another unrelated bug in the video driver.

[Laurent]

I've pushed the modification. Please confirm that it still works

And what about other OSes? Does anybody have similar problems on Windows or OS X?

[Nexus]

Is there a minimal code we can directly test? (Maybe the one from Haikarainen's 2nd post?)

What problems were there exactly?

[Szunti]

Shader example start, but when I quit gives:

X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  2 (X_ChangeWindowAttributes)
  Resource id in failed request:  0x1a00007
  Serial number of failed request:  1000
  Current serial number in output stream:  1010
 

which it doesn't do with 1display branch.

EDIT: it happens at the deletion of the last effect.

It seems I suck with gdb + C++, but if you need more info I can try it harder.

Btw it looks wrong to call window.draw(..) and window.display() after window.close() in the example, but it's not the problem, because I changed the order and the error remains.

The examples in this thread works without problem.

[Laurent]

Is there a minimal code we can directly test? (Maybe the one from Haikarainen's 2nd post?)

Calling RenderTexture create/clear/display is enough to trigger the problem.

which it doesn't do with 1display branch.

Hum
Do you see any major difference between the new code and your branch?

Btw it looks wrong to call window.draw(..) and window.display() after window.close()

It's not a problem, these are no-op when the window has been closed.

[Ceylo]

And what about other OSes? Does anybody have similar problems on Windows or OS X?

No problem on OS X with the shader example and an integrated Intel GPU.

[Szunti]

XFlush on GlxContext.cpp:124 is where it gives the error.

Maybe it's something with the deleted  m_ownsWindow, but I'm too lazy to find out what that does.