HSL Color Standard

[masskiller]

I'd like to propose to add the HSL (Hue, Saturation, Luminance) Coloring to SFML.

I have been investigating HSL Coloring system for a bit, while it's true that it's nowhere near as useful as RGBA is, however it allows easy color transformations such as colorizing an image with a given color in an easy way.

Here's an example: http://www.tannerhelland.com/3552/colorize-image-vb6/

This cannot be done in an easy way with RGB and I think that it would give the library another powerful tool if implemented. I don't think that HSL is good for being able to be used the same way as RGB, yet still to be able to colorize and manipulate colors in that way and give the user that freedom is what gave me the idea to suggest this into SFML.

So what do you think about this? Is it a good idea or not practical at all? I am implementing it myself for my game, but I think it'd be nice to see this in a future version of SFML.

[Laurent]

This is something that doesn't require modifications to SFML, it can (and must) be written on top of sf::Color. So I don't see good reasons for integrating it directly.

But you can share your code on the wiki

[Nexus]

I have already thought about adding a HSV or HSL color class to Thor. But don't expect it too soon, I'm still stuck with other design issues (particles/animations)

[masskiller]

But you can share your code on the wiki

I'm nearly done with it, as soon as I am done implementing what's left and documenting it I'll share it.

[quarks]

I don't see any license inormation for this piece of code:
https://github.com/SFML/SFML/wiki/SourceHSLColor

Maybe the author is still arround ?

In case so, may I suggest you to add the same license header than SFML ?

Otherwise the only things we can do is either to read it only, or stealing it in the copyright violation way.

Thanks for your understanding

[eXpl0it3r]

Well mostly don't include any license... I guess Laurent will introduce a rule that if not otherwise specified the code provided in the wiki will be in the public domain. I'd also say that's mostly what the authors think of, otherwise they wouldn't publicise code there.

If you look at the page history then you see that the original author is maskedkiller01 which sounds suspicously similar to masskiller...
And there was an edit just a few minutes ago by blue-prawn, that's either quarks or this user.

[quarks]

If you look at the page history then you see that the original author is maskedkiller01 which sounds suspicously similar to masskiller...

Obviously

And there was an edit just a few minutes ago by blue-prawn, that's either quarks or this user.

And ?

OK, there is this page too: https://github.com/SFML/SFML/wiki/Tutorial:-Manage-dynamic-key-binding
from "eXpl0it3r" which is probably the same than on the forum "eXpl0it3r", also edited by "blue-prawn" 6 minutes ago

So may I assume that the code that you provide on the wiki is public domain?

[eXpl0it3r]

So may I assume that the code that you provide on the wiki is public domain?

This isn't my code... I'm not sure how GitHub handles these pages but for some reason it doesn't show the first change... So maybe one can't go after the history.

[quarks]

This isn't my code... I'm not sure how GitHub handles these pages but for some reason it doesn't show the first change... So maybe one can't go after the history.

Great!
this is very handy to contact the original authors, to ask them about licensing issues.

On the old wiki, I found this:
http://www.sfml-dev.org/wiki/en/sources/pausableclock

I was able to ask the author if he accepts to switch from cc-by-sa to the same license than SFML.
He accepted.

IMO we should fix the licensing issue on the wiki before there are too many things.

Also I noticed later that the code from "PausableClock" seems to be the same than here:
https://github.com/Bromeon/Thor/blob/master/src/StopWatch.cpp

but the name of the author is different !??

[eXpl0it3r]

IMO we should fix the licensing issue on the wiki before there are too many things.

Yeah... Laurent?

Also I noticed later that the code from "PausableClock" seems to be the same than here:
https://github.com/Bromeon/Thor/blob/master/src/StopWatch.cpp

but the name of the author is different !??

I've no idea how you'd think that this is the same code...
Make a diff and you won't find any matches.
And for the idea, you can't copyright that...

But all that beside the one author is Hirua and the other is Nexus and I think they know each other from the forum well enough to not fighter over such code ideas. Both are contributing extensively to SFML so worry not...

Ah, and Thor as the same license than SFML, so you can do with that code whatever you want.

[quarks]

I've no idea how you'd think that this is the same code...
Make a diff and you won't find any matches.

This is the same code, only the variable and class names are different.
The implementation is exactly the same, while one could implement this in different ways.
So please...

But all that beside the one author is Hirua and the other is Nexus and I think they know each other from the forum well enough to not fighter over such code ideas. Both are contributing extensively to SFML so worry not...

Of course noone will raise a trial for 10 lines of code.
When I read this, I was just surprised to see the same code without cite the original author.

[FRex]

Chances are that if you told us the interface and functionality these two have, we would write similar code without knowing the original code. There's only so many ways to implement things.

And for the idea, you can't copyright that...

I like to point out how much I hate Apple in moments like that.

[Laurent]

Yeah... Laurent?

I don't have the time to manage the wiki. There are so many things to do on it (fix the titles/page names, change the rules, add the default license, review the recent modifications and additions, ...).

It would be great if someone could manage this wiki

[eXpl0it3r]

It would be great if someone could manage this wiki

I guess I could do some stuff...
I'm unsure though, if it makes sense to change all the titles, because it will probably break every link on the forum to a specific topic, then again that's just a small problem and the bigger win would be a nice title naming scheme...

[Laurent]

Yeah, I don't know exactly how to handle existing URLs. But since github change the way they work, something must be done. At least update the rules.