1
SFML development / Re: PR for issue 2312
« on: January 06, 2023, 05:12:45 pm »
Thanks, I opened https://github.com/SFML/SFML/pull/2334
Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Pages: [1]
2
SFML development / PR for issue 2312
« on: January 06, 2023, 07:04:55 am »
I'd like to submit a PR addressing issue #2312 (Remove defaulted or empty, non-virtual destructors): https://github.com/SFML/SFML/issues/2312
The changes are in the branch feature/clang-tidy-modernize. I started by introducing a small set of the modernize-* checks into the .clang-tidy file to mark constructors/destructors as =default and =delete as appropriate, then removed the non-virtual =default destructors.
Arguably, =default constructors should be removed as well, since the compiler will generate them anyway.
The changes are in the branch feature/clang-tidy-modernize. I started by introducing a small set of the modernize-* checks into the .clang-tidy file to mark constructors/destructors as =default and =delete as appropriate, then removed the non-virtual =default destructors.
Arguably, =default constructors should be removed as well, since the compiler will generate them anyway.
Pages: [1]