Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: PR for issue 2312  (Read 1032 times)

0 Members and 1 Guest are viewing this topic.

Gnawme

  • Newbie
  • *
  • Posts: 2
    • View Profile
    • Email
PR for issue 2312
« on: January 06, 2023, 07:04:55 am »
I'd like to submit a PR addressing issue #2312 (Remove defaulted or empty, non-virtual destructors): https://github.com/SFML/SFML/issues/2312

The changes are in the branch feature/clang-tidy-modernize. I started by introducing a small set of the modernize-* checks into the .clang-tidy file to mark constructors/destructors as =default and =delete  as appropriate, then removed the non-virtual =default destructors.

Arguably, =default constructors should be removed as well, since the compiler will generate them anyway.

eXpl0it3r

  • SFML Team
  • Hero Member
  • *****
  • Posts: 10801
    • View Profile
    • development blog
    • Email
Re: PR for issue 2312
« Reply #1 on: January 06, 2023, 09:16:16 am »
Note that there's already a PR open: https://github.com/SFML/SFML/pull/2321

But the clang tidy part would still be interesting to see.
So I suggest you just open a PR and then we can go from there. :)
« Last Edit: January 06, 2023, 06:43:02 pm by eXpl0it3r »
Official FAQ: https://www.sfml-dev.org/faq.php
Official Discord Server: https://discord.gg/nr4X7Fh
——————————————————————
Dev Blog: https://duerrenberger.dev/blog/

Gnawme

  • Newbie
  • *
  • Posts: 2
    • View Profile
    • Email
Re: PR for issue 2312
« Reply #2 on: January 06, 2023, 05:12:45 pm »

 

anything