A Thread and RenderWindow issue - My poor Super Mario

[Tigre Pablito]

Hello Ladies and Guys from SFML

I'm extending my Super Mario game, and decided to introduce multithreading to increase its performance

Before, I had something like this in my main loop:

while (true)
{
     DrawBackground();

     DrawLevelPlace();

     DrawSuperMario();

     DrawEnemies();

     DrawForeground();

     delay();
}
 

Now I'm changing each function into the loop by

void DrawLevelPlace()
{
      while()
      {
           the same than before
      }
}

and remove it from the main thread main loop and

Thread thread1 = new Thread(new ThreadStart(DrawLevelPlace));

thread1.Start();

 

********
It produces a console message: "Failed to activate window's context" repeated several times

I admit I'm not an expert in multithreading, just know the basics, but I learn fast

Would you help me?

Thanks

this is the last version of the program that I upload to dropbox

https://www.dropbox.com/s/2v13d30js73bhsb/My%20New%20Super%20Mario%20Bros.rar

[Laurent]

Two things:

1. The answer is written in the tutorials (see "OpenGL" and/or "Drawing").

2. I think you have no idea of what you're doing. You want to improve your program but you're making it slower and much less maintainable. Forget about multithreading, or read/practice more to know how to use it to actually improve things

[Tigre Pablito]

Thank you, Laurent

Could you give me the link, web address, or how to reach the place where the answer is written?
I googled "sfml tutorals" and didn't find it

Actually, not only I want to improve my game, also I want to practise and learn multithreading, I think it is the greatest thing of .NET

I don't know if you saw the game in the link, it isn't multithreaded, it's the last update I uploaded ... maybe it's slow cos it isn't multithreaded ...
Don't worry, I'll learn well, I love programming and games, and my brain is almost the only thing I have

Thanks again

[Laurent]

Could you give me the link, web address, or how to reach the place where the answer is written?
I googled "sfml tutorals" and didn't find it

SFML tutorials are there: http://www.sfml-dev.org/tutorials/2.1/

Actually, not only I want to improve my game, also I want to practise and learn multithreading, I think it is the greatest thing of .NET

Fair enough
But keep in mind that you won't improve anything. You only have one physical graphics card, so what do you think you'll gain from drawing from multiple threads? And you'll also discover that drawing to the same target from multiple threads is not easy, because of lower-level constraints.

I don't know if you saw the game in the link, it isn't multithreaded, it's the last update I uploaded ... maybe it's slow cos it isn't multithreaded ...

Don't guess. Profile your code.

[binary1248]

I must get really lucky when using Google then...

[TheRabbit]

It's probably only because you spelled tutorial wrong 

Tigre, if you do multi-threading the way you explained it in your main post, you'll end up with several race conditions and probably some bad synchronization problems. I'd strongly suggest reading up some more on multi-threading once you get it running (specifically on the two topics I just mentioned).

[Tigre Pablito]

Thank you all, Guys (and Ladies)

I was lucky to find the answer considering I'm very inept on searching, plus I'm lazy

.... Not so lucky as binary1248, but I stand .... (1048576 hi hi hi) ... even that I spell correctly, in general

Laurent, I can't compare with your knowledges, but I think that what you gain with multithreading concerns more to processing code, that is, not when the cpu draws to the screen, but when it thinks and does calculations, ... and in my poor Super Mario that is quite important part (trajectories, movements, attacks, scrolls, etc ...)

TheRabbit, you're right, troubles exist ... I'll get through them, ... and these are not the worst, in any way or another I'll learn this interesting issue

And, actually I applied what I read from the tutorial and now the application already runs vissibly faster, though there appeared a few problems, I'm working on that ... but it works, now I see again the graphics

Thanks to you   

Before you remember me, I'll post the link to my poor Mario very very improved   
 

[Laurent]

I think that what you gain with multithreading concerns more to processing code, that is, not when the cpu draws to the screen, but when it thinks and does calculations, ... and in my poor Super Mario that is quite important part (trajectories, movements, attacks, scrolls, etc ...)

If trajectories, movements, attacks, scrolls, etc ... are all done in the Draw functions, then they are very badly named. And I still assume that they contain the drawing code, which should not be scattered in multiple threads.

[cuddlyogre]

I learned recently just how much of a fool's errand multithreading really is, unless you really know what you're doing. I would recommend looking into how to implement a quadtree to limit how much your game has to do. It is far less maddening to deal with.