Help with the design for selecting audio capture device

[Laurent]

Thanks

I noticed that, in case of a call to setDevice(""), getDevice() will return "" until the next capture starts, and the actual default device name after (even after the capture was stopped). If we don't call setDevice(""), getDevice() will always return the actual name of the default device. This feels a little inconsistent. Maybe you should retrieve the name of the default device in setDevice if the argument if an empty string, and then remove the calls to alcGetString(captureDevice, ALC_CAPTURE_DEVICE_SPECIFIER) in start and setDevice.

Also, what happens if the default device changes (I guess it can be changed in the OS control panel -- or, if you can set your USB webcam as the default device, it can be hot-plugged/unplugged) during runtime? Does the empty string correctly map to the new default device, or does OpenAL always returns the same initial default device? Would you be able to test this use case?

[Foaly]

That is indeed a bug! I fixed it. The name of the default device is now stored if setDevice() is called with an empty string.

I did some test with hot-plugging the devices and it seems like OpenAL doesn't map getDefaultDevice() correctly to the next device, if you unplug the default device. It uses the initial default device. Of course if you try to keep on using it there are OpenAL errors. The list of getAvailableDevices() on the other hand is always up to date.

[Laurent]

Bug: if calling setDevice while recording fails, m_deviceName will never be updated.

[Foaly]

I am not sure if I'd call that a bug. I think it is the expected behaviour. If the setDevice() fails, the selected device fails to open and captureDevice is not set, so why store the name?

[Laurent]

Because if you were not in the middle of a capture, the device is assigned and all subsequent captures will fail until it is changed again.

[Foaly]

Ok I updated the code.

[Laurent]

Why don't you just move the "// Store the device name" block at the beginning of the function? The current code is inconsistent, you don't store the same thing in both cases (if an empty string is passed).

[Nexus]

Sorry for offtopic, but I just stumbled about new GitHub features which intend to make pull requests easier to process (if you use the Git for Windows application). It's not ideal, but might still be worth reading.

• https://github.com/blog/1582-checking-out-pull-requests
• https://github.com/blog/1650-opening-files-from-pull-requests-and-branches

Nice new logo, by the way.

Thanks! I found it's time to give my whole website a new look

[Foaly]

Sorry I won't be near my computer for a couple days. I'll try to fix it next week!

[Foaly]

OK it is consistend now! sorry about that I was distracted when I wrote the last fix...

[Laurent]

Make getDevice return a const reference, merge everything into a single clean commit, and I'll integrate it. Finally

[Foaly]

Awesome!
I did the first thing, but I don't know how to merge the whole pull request into a single commit. I only know some basic git commands, so if somebody could explain to me how it's done, that would be great!

[Nexus]

git rebase -i <rev>, where <rev> is the first of your commits. When the text editor opens the file, replace all "pick" words by "squash", store the file and close it.

You may need to force-push (git push -f) to rewrite the history to GitHub.

[Foaly]

Ok. I'm not sure I understood everything, but I'll try. How to I get the <rev>?

edit: Would it be this one: 005396d32f3f302560e2553dc26acb60f4952b33

[Nexus]

<rev> is the hash of the first commit you made.

It suffices to enter the first 5-7 characters of the hash, as long as it is not ambiguous.