Welcome, Guest. Please login or register. Did you miss your activation email?

Author Topic: Help with the design for selecting audio capture device  (Read 32559 times)

0 Members and 1 Guest are viewing this topic.

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #60 on: October 08, 2013, 11:08:51 pm »
I used git rebase -i 005396d32 and replaced every "pick" with "squash". I got the error message: Can not 'squash' without previous commit.
Do I have to leave the first pick and only make every following to a squash?

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #61 on: October 09, 2013, 12:09:40 am »
I don't know... I tryed for the last hours and I think I got it right now, excpet that I have to find out how to change the commit message  :D

Nexus

  • SFML Team
  • Hero Member
  • *****
  • Posts: 6287
  • Thor Developer
    • View Profile
    • Bromeon
Re: Help with the design for selecting audio capture device
« Reply #62 on: October 09, 2013, 12:43:34 am »
Yes sorry, there must be at least one "pick" (the first one). Thus, <rev> is the last commit before yours, so the rebase text file will contain all of your commits.

Use git commit --amend to change the last commit, or git rebase -i with "reword" instead of "pick".
Zloxx II: action platformer
Thor Library: particle systems, animations, dot products, ...
SFML Game Development:

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #63 on: October 09, 2013, 08:48:24 am »
Alright I changed the commit message.
I'm not 100% sure that I did everything right, because there where some merge conflicts that I had to resolve. I hope I did everything right, but if somebody could have a look at it again, that would be great!
Other than that I think we are good to go now :D and thanks for the help!

Hiura

  • SFML Team
  • Hero Member
  • *****
  • Posts: 4321
    • View Profile
    • Email
Re: Help with the design for selecting audio capture device
« Reply #64 on: October 09, 2013, 08:51:33 am »
Nice. There are still two commits but it's already better. I think you can rebase with a branch too (instead of a commit sha). Something like `git rebase -i master` and squash the second commit into the first one.
SFML / OS X developer

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #65 on: October 09, 2013, 09:22:50 am »
I tryed that and now everything is in one commit. I think we are good to go now!  ;D
Thanks again!
I found a site that shows how to squash all commit of a pull request into one (of course you always find those things after you're done... but maybe it's helpful for the next person).

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32498
    • View Profile
    • SFML's website
    • Email
Re: Help with the design for selecting audio capture device
« Reply #66 on: October 10, 2013, 07:49:41 am »
I think something is wrong. Look at setDevice for example, it's not the latest version of the code.

I hope you kept a local copy of the code before you merged everything :P
Laurent Gomila - SFML developer

Nexus

  • SFML Team
  • Hero Member
  • *****
  • Posts: 6287
  • Thor Developer
    • View Profile
    • Bromeon
Re: Help with the design for selecting audio capture device
« Reply #67 on: October 10, 2013, 08:12:39 am »
I hope you kept a local copy of the code before you merged everything :P
Otherwise, there's still git reflog ;)
Zloxx II: action platformer
Thor Library: particle systems, animations, dot products, ...
SFML Game Development:

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #68 on: October 10, 2013, 10:29:51 am »
For fuck sacks... I knew something like that would happen! Of course I didn't back the files up before I merged them. How can I restore them?

edit: I took a look at setDevice again and I don't noticed anything wrong. What did you see that is wrong?

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32498
    • View Profile
    • SFML's website
    • Email
Re: Help with the design for selecting audio capture device
« Reply #69 on: October 10, 2013, 06:38:02 pm »
The latest code was:
if (device.empty())
    m_deviceName = getDefaultDevice();
else
    m_deviceName = device;

...
Laurent Gomila - SFML developer

Nexus

  • SFML Team
  • Hero Member
  • *****
  • Posts: 6287
  • Thor Developer
    • View Profile
    • Bromeon
Re: Help with the design for selecting audio capture device
« Reply #70 on: October 10, 2013, 07:17:41 pm »
How can I restore them?
Read my post ;)
Zloxx II: action platformer
Thor Library: particle systems, animations, dot products, ...
SFML Game Development:

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #71 on: October 10, 2013, 08:17:47 pm »
Laurent are you 100% sure it was like that? Because I am almost certainly sure, that there was never a variable device (because of the confusion with the actual device handle). I always used name or deviceName. And also the latest commit moved the // Store name block to the top of the method, where it is now. So maybe there is nothing wrong.

Nexus

  • SFML Team
  • Hero Member
  • *****
  • Posts: 6287
  • Thor Developer
    • View Profile
    • Bromeon
Re: Help with the design for selecting audio capture device
« Reply #72 on: October 10, 2013, 09:00:34 pm »
Of course you can also guess, if you prefer that to checking the reflog.
Zloxx II: action platformer
Thor Library: particle systems, animations, dot products, ...
SFML Game Development:

Laurent

  • Administrator
  • Hero Member
  • *****
  • Posts: 32498
    • View Profile
    • SFML's website
    • Email
Re: Help with the design for selecting audio capture device
« Reply #73 on: October 10, 2013, 09:18:43 pm »
Indeed it looks ok. I must have looked at the wrong commit. But you'd better be 100% sure, manual checking won't be enough, there were so many changes to the code.
Laurent Gomila - SFML developer

Foaly

  • Sr. Member
  • ****
  • Posts: 453
    • View Profile
Re: Help with the design for selecting audio capture device
« Reply #74 on: October 11, 2013, 12:38:08 am »
So what should I do?

 

anything