Should i use this game loop?

[slucis7593]

Hi !
I put render() method into while loop like this:

void Application::run()
{
        sf::Clock clock;
        sf::Time timeSinceLastUpdate = sf::Time::Zero;

        while (mWindow.isOpen())
        {
                sf::Time dt = clock.restart();
                timeSinceLastUpdate += dt;
                while (timeSinceLastUpdate > TimePerFrame)
                {
                        timeSinceLastUpdate -= TimePerFrame;

                        processInput();
                        update(TimePerFrame);

                        // Check inside this loop, because stack might be empty before update() call
                        if (mStateStack.isEmpty())
                                mWindow.close();

                        render();
                }

                updateStatistics(dt);
        }
}

and here is result, FPS is very high but it's seem not stability:


So, i want to ask that should i use this game loop?
Thanks

[Jesper Juhl]

This post really belongs in the help section, but anyway; I believe this will help you: http://en.sfml-dev.org/forums/index.php?topic=15175.msg107603#msg107603

[slucis7593]

This post really belongs in the help section, but anyway; I believe this will help you: http://en.sfml-dev.org/forums/index.php?topic=15175.msg107603#msg107603

Oh, i'm sorry , i'm newbie and thank you for your help

[Geheim]

                        render();
                }

                updateStatistics(dt);
        }
 

Looks like only these two have to be swapped and you should pass TimePerFrame to your updateStatistics function instead of dt, like you did with your update function.

Audio is a strange title btw haha

[slucis7593]

Looks like only these two have to be swapped and you should pass TimePerFrame to your updateStatistics function instead of dt, like you did with your update function.

Audio is a strange title btw haha

actually, this source code come from 'SFML Game Development' Book and original code is:

void Application::run()
{
    sf::Clock clock;
    sf::Time timeSinceLastUpdate = sf::Time::Zero;

    while (mWindow.isOpen())
    {
        sf::Time dt = clock.restart();
        timeSinceLastUpdate += dt;
        while (timeSinceLastUpdate > TimePerFrame)
        {
            timeSinceLastUpdate -= TimePerFrame;

            processInput();
            update(TimePerFrame);

            // Check inside this loop, because stack might be empty before update() call
            if (mStateStack.isEmpty())
                mWindow.close();
        }

        updateStatistics(dt);
        render();
    }
}