Letterbox effect using a view

[AFS]

Hello.

I added a little code example to archieve a letterbox effect when resizing the window, having black bars on the sides in case the aspect ratio of the window is different than the aspect ratio of the view.

https://github.com/SFML/SFML/wiki/Source:-Letterbox-effect-using-a-view

I was unsure whether this is "wiki material" or not, but I decided to post it regardless. Maybe someone finds it useful.

Any corrections or suggestions are welcome, of course.

Cheers!

Edit: typo.

[G.]

Good idea! 

[Hapax]

Aha! You beat me to it! I was going to do just this 

[santiaboy]

Nice idea!

Why don't you use

void getLetterboxView(sf::View& view, int windowWidth, int windowHeight)
 

instead of

sf::View getLetterboxView(sf::View view, int windowWidth, int windowHeight)
 

?
It will avoid unnecessary copying.

[Hapax]

That would alter the original view (or try to). That might not be desired, or may be a const view (renderWindow.getView() for example).

[Cirrus Minor]

Great 
I've just integrated it in my current project, it's working fine!

[Nexus]

santiaboy, this approach has several disadvantages. Such a function cannot be used for initialization, it's impossible to initialize const variables, it needs 2 lines instead of one. The advantage is very questionable: copying small classes is cheap (and assignment is needed anyway, also for output parameters), larger classes can provide move semantics.

Avoid premature optimization, especially if it complicates code.