Trouble with sf::Music

[zzzzlzzzz]

Hello, i write simple game with SFML.
I using sf::Sound and all is ok. If i use sf::Music periodically i get error in console:

(click to show/hide)

...
An internal OpenAL call failed in SoundSource.cpp(177).
Expression:
   alGetSourcei(m_source, AL_SOURCE_STATE, &status)
Error description:
   AL_INVALID_OPERATION
   The specified operation is not allowed in the current state.

An internal OpenAL call failed in SoundStream.cpp(312).
Expression:
   alSourcePlay(m_source)
Error description:
   AL_INVALID_OPERATION
   The specified operation is not allowed in the current state.

An internal OpenAL call failed in SoundStream.cpp(324).
Expression:
   alGetSourcei(m_source, AL_BUFFERS_PROCESSED, &nbProcessed)
Error description:
   AL_INVALID_OPERATION
   The specified operation is not allowed in the current state.

An internal OpenAL call failed in SoundSource.cpp(177).
Expression:
   alGetSourcei(m_source, AL_SOURCE_STATE, &status)
Error description:
   AL_INVALID_OPERATION
   The specified operation is not allowed in the current state.

An internal OpenAL call failed in SoundSource.cpp(177).
Expression:
   alGetSourcei(m_source, AL_SOURCE_STATE, &status)
Error description:
   AL_INVALID_OPERATION
   The specified operation is not allowed in the current state.
...

My code:

(click to show/hide)

musicFiles - array of strings filename
curMusicFile - iterator to array

        void MusicPlayer::playNext()
        {
                if (!musicPlayer->openFromFile(*(curMusicFile++)))
                        throw runtime_error("GameSpace::MusicPlayer::doPlay openFromFile error");

                musicPlayer->play();

                curLength = musicPlayer->getPlayingOffset();
        }
        //////////////////////////////////////////////////////////////////////////
        void MusicPlayer::doPlay(const sf::Time& delta)
        {
                if (!musicFiles.empty())
                {
                        if (!musicPlayer)
                        {
                                curMusicFile = musicFiles.begin();
                               
                                musicPlayer = unique_ptr<Music>(new Music());

                                playNext();
                        }
                        else
                        {
                                curLength += delta;
                                if (curLength >= musicPlayer->getDuration())
                                {
                                        if (curMusicFile == musicFiles.end())
                                                curMusicFile = musicFiles.begin();

                                        musicPlayer->stop();

                                        playNext();
                                }
                        }
                }
        }

in main:

MusicPlayer mp;
mp.addMusic("file.wab");
Clock gameTime;
while (mainWindow.isOpen())
{
        mp.doPlay(gameTime.getElapsedTime());
        doLogic(gameTime.restart().asMicroseconds() / 800.0f);
        ...
}
 

Please, tell me where my mistake. And sorry for my bad english.

[Hapax]

What is musicPlayer?

You should read this article. It's really important. Most specifically, this part.

[zzzzlzzzz]

Thanks for reply!

The my demo code is:

(click to show/hide)

#include <memory>
#include <list>

#include <SFML/Graphics.hpp>
#include <SFML/Audio.hpp>

using namespace std;
using namespace sf;

class MusicPlayer
{
        std::unique_ptr<sf::Music> musicPlayer;
        sf::Time musicLength;
        sf::Time curLength;
        std::list<std::string> musicFiles;
        std::list<std::string>::iterator curMusicFile;
        void playNext()
        {
                musicPlayer->openFromFile(*(curMusicFile++));

                musicPlayer->play();

                curLength = musicPlayer->getPlayingOffset();
        }
public:
        void addMusic(const std::string& file)
        {
                musicFiles.push_back(file);
        }
        void doPlay(const sf::Time& delta)
        {
                if (!musicFiles.empty())
                {
                        if (!musicPlayer)
                        {
                                curMusicFile = musicFiles.begin();

                                musicPlayer = unique_ptr<Music>(new Music());

                                playNext();
                        }
                        else
                        {
                                curLength += delta;
                                if (curLength >= musicPlayer->getDuration())
                                {
                                        if (curMusicFile == musicFiles.end())
                                                curMusicFile = musicFiles.begin();

                                        musicPlayer->stop();

                                        playNext();
                                }
                        }
                }
        }
};

int main(int argc, char* argv[])
{
        RenderWindow rwMain(VideoMode(640, 480), "Test App", Style::Default);
        rwMain.setFramerateLimit(60);

        MusicPlayer mp;
        mp.addMusic("1.ogg");

        Clock clck;
        while (rwMain.isOpen())
        {
                mp.doPlay(clck.restart());

                Event evItem;
                while (rwMain.pollEvent(evItem))
                {
                        if (evItem.type == Event::Closed)
                                rwMain.close();
                }

                rwMain.clear(Color::White);
                rwMain.display();
        }

        return 0;
}
 

If i run this without creating window - all ok (infinite loop). I think, trouble generated in call sf::Music::play (may be i wrong).

I use SFML from git and from official site.
My OS: Windows 7 x64
My IDE: Visual Studio 2013
I build x32 application and x32 version sfml.

[Hapax]

What is the problem you're having with it?

This code compiles and starts playing the music.


EDIT:
It looks like you forgot to use musicLength to represent the music's duration. Doesn't look like it's needed though...

Why are you using curLength to keep track of the position in the music when sf::Music has getPlayingOffset()?

Moreover, why use that to see if the music has finished? Why not, instead, use getStatus() to test if it has finished playing?

Why are you using using namespace sf and using namespace std and specifying (sometimes) the sf:: and std:: prefixes? Just remove the "using namespace"s, add the prefixes and stop being lazy 

[zzzzlzzzz]

My current code:

(click to show/hide)

#include <memory>
#include <list>

#include <SFML/Graphics.hpp>
#include <SFML/Audio.hpp>

class MusicPlayer
{
        std::unique_ptr<sf::Music> musicPlayer;
        std::list<std::string> musicFiles;
        std::list<std::string>::iterator curMusicFile;
        void playNext()
        {
                musicPlayer->openFromFile(*(curMusicFile++));

                musicPlayer->play();
        }
public:
        void addMusic(const std::string& file)
        {
                musicFiles.push_back(file);
        }
        void doPlay()
        {
                if (!musicFiles.empty())
                {
                        if (!musicPlayer)
                        {
                                curMusicFile = musicFiles.begin();

                                musicPlayer = std::unique_ptr<sf::Music>(new sf::Music());

                                playNext();
                        }
                        else
                        {
                                if (musicPlayer->getStatus() == sf::SoundSource::Stopped)
                                {
                                        if (curMusicFile == musicFiles.end())
                                                curMusicFile = musicFiles.begin();

                                        musicPlayer->stop();

                                        playNext();
                                }
                        }
                }
        }
};

int main(int argc, char* argv[])
{
        sf::RenderWindow rwMain(sf::VideoMode(640, 480), "Test App", sf::Style::Default);
        rwMain.setFramerateLimit(60);

        MusicPlayer mp;
        mp.addMusic("1.ogg");

        sf::Clock clck;
        while (rwMain.isOpen())
        {
                mp.doPlay();

                sf::Event evItem;
                while (rwMain.pollEvent(evItem))
                {
                        if (evItem.type == sf::Event::Closed)
                                rwMain.close();
                }

                rwMain.clear(sf::Color::White);
                rwMain.display();
        }

        return 0;
}

My problem shown sometimes. In console shown messages (in first post) and music not played. And next program crashed. Many run my program work fine.
I don't understand reasons error.

Maybe, main reasons - it is my OS? I use OpenAL from distributibe SFML.

P.S. Messages show in console asynchronously. Sometimes message crossed. (exmpl. An internal iled in SoundSource.cpp(177) OpenAL call failed in SoundSource.cpp(177).)

[Hapax]

it is my OS?

I don't think so. My set up seems identical.

I use SFML from git and from official site.

Just noticed this that you posted earlier. You said "from git and official site." What does this mean?
Have you tried both? If so, it's possible that you may be mixing libraries. e.g. using DLLs from a different version to the code you're including.

[zzzzlzzzz]

About dll: i test my code with version on sfml-dev (and his dll), and with version on git (and his dll). I make this for get more detailed error report.

I don't know how repeat condition for generation my problem, and very strange that my problem generated sometimes.

[Hapax]

I'm not certain what you mean by "problem". Is the problem that error codes and the eventually crashing, or are there artifacts in the sound/sound doesn't play?

How does it crash? What messages do you get? Where in the code does it stop?

Are you building in debug or release mode? Are the problems the same in both?

The more information you can provide about the actual problem could help a lot.

[zzzzlzzzz]

I test my game in two case: use precompiled sfml and use git version.
If i use precompiled version game not play music, show message in console, and crashed because stack overflow. Messages similar to git version messages, but short (show source file, line number and short error type (exmpl.  AL_INVALID_OPERATION))
If i use git version game not play music and show message in console (first post).
It happened sometimes in debug version. In release all ok.

After i recompile all project file and library problem gone. I'm not sure that it's solving my problem, but program working.