Module membership for sf::Packet

[Glocke]

Hi, I've been using sf::Packet quite a while to prepare game data for being written to binary files (because of the builtin byte order handling). This makes e.g. savegames easily cross-platform. I understand that this functionality is also used while networking. But is it really necessary to attach the class to the networking module?

It isn't a big deal .. but more a question of grouping. Personally, I'd expect such things within the system module of SFML. Any thoughts on that?

Glocke

[Laurent]

It depends on system networking libs, so yes, it must be in the network module.

[Glocke]

It depends on system networking libs, so yes, it must be in the network module.

You mean those byteorder-version functions? Good point!!

[FRex]

It's also friends with the two socket classes to allow calling virtual protected member functions...
Ntohs, etc. functions would be easy to get rid of compared to thinking how to do that differently.
And Packet (from its description in docs) seems to be meant mainly for networking, not as a binary data store in general.
There are plenty of nice, easy and human readable formats to save data as, that might be nicer (but less cool ) for development and debugging.

[Mario]

While SFML might be convenient, look into serialization libraries for things like this. How about giving Cereal a try?