Why does it delete the last charachter

[anttton]

Hello, I always get "out of range" when I delete a the invisble charachter. I dont know why I run into this error. I have search and include the s1.getSize so I can see how big the string is but I dosent seem to work.

S1 is a SF::string
CharachterName is a SF::Text

if (event.type == sf::Event::TextEntered)
                {
                                if (event.text.unicode == '\b' && s1.getSize() > 0)
                                {
                                        s1.erase(s1.getSize() - 1, 1);
                                        this->characterName->setString(s1);
                                }
                       
               
                                if (event.text.unicode < 128)
                                {
                                        s1 += static_cast<char>(event.text.unicode);
                                }              
                        else
                        {
                        }
                        break;
                }
 

[eXpl0it3r]

The easier solution with C++11 is to use s1.pop_back(), no index juggling and quite expressive.

[anttton]

Hey, I can not use .pop_back with s1 insted of s1.erase(s1.getSize() - 1, 1). Have I done something wrong?
I think you only can use pop_back if its a std::string

[eXpl0it3r]

Ah, I didn't realize s1 was a sf::String.

I took your code and made a minimal example out of it and it seems to work fine.

#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderWindow window(sf::VideoMode(800, 600), "Test");
    window.setVerticalSyncEnabled(true);

    sf::Font font;
    font.loadFromFile("arial.ttf");

    sf::String s1;
    sf::Text txt(s1, font);

    while(window.isOpen())
    {
        sf::Event event;
        while(window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
            {
                window.close();
            }

            if (event.type == sf::Event::TextEntered)
            {
                if (event.text.unicode == '\b')
                {
                    if (s1.getSize() > 0)
                        s1.erase(s1.getSize() - 1, 1);
                }
                else if (event.text.unicode < 128)
                {
                    s1 += static_cast<char>(event.text.unicode);
                }

                txt.setString(s1);
            }
        }

        window.clear();
        window.draw(txt);
        window.display();
    }
}

I guess your error must come from a different place than what you thought.
I noticed that with the posted code, you're still adding the backspace character to the string, as such I moved the size condition inside the other if block and added an else if for the second block.

[anttton]

Thank you for the help, It work now!