[SOLVED] How can I make a rectangle follow the mouse cursor?

[Blingu]

Hi, I'm currently writing a simple game.
I want a rectangle to be at the cursor's position whenever the mouse has been moved. I found a solution on how to do it, but it's not working like it actually should. The rectangle is always located the same distance away, just like in the picture below (yellow dot imitates the cursor, it hasn't been caught on print screen):

(click to show/hide)

Code:

(click to show/hide)

//main.cpp
#include "Game.h"

int main()
{
        Game game;
        game.Loop();

        return 0;
}

//Game.h
#pragma once
#include <SFML/Graphics.hpp>
#include "Player.h"

class Game
{
private:
        sf::RenderWindow *window;
        Player *player;

public:
        Game();
        void Loop();
};

//Game.cpp
#include <SFML/Graphics.hpp>
#include "Game.h"
#include "Player.h"
#include <iostream>

Game::Game()
{
        window = new sf::RenderWindow(sf::VideoMode(500, 500), "Game");
        player = new Player();
}

void Game::Loop()
{

        while (window->isOpen())
        {
                sf::Event event;
       
                while (window->pollEvent(event))
                {
                        switch (event.type)
                        {
                            case sf::Event::Closed:
                                        window->close();
                                        break;
                               
                                case sf::Event::MouseMoved:
                                        player->Move();
                                        break;
                        }
                }

                window->clear();
                //draw here
                player->Draw(window);

                window->display();
        }
}


//Player.h
#pragma once
#include <SFML/Graphics.hpp>

class Player
{
private:
        sf::RectangleShape player;

public:
        Player();
        void Draw(sf::RenderWindow *window);
        void Move();
};

//Player.cpp
#include "Player.h"
#include "SFML/Graphics.hpp"

Player::Player()
{
        player.setSize(sf::Vector2f( 20.f, 20.f ));
        player.setFillColor(sf::Color::Green);
        player.setPosition(sf::Vector2f( 50.f, 50.f ));
}

void Player::Draw(sf::RenderWindow *window)
{
        window->draw(player);
}

void Player::Move()
{
        player.setPosition(sf::Vector2f( sf::Mouse::getPosition().x, sf::Mouse::getPosition().y ));
}



 

I hope to receive some advice on how to do it, thanks in advance.

[eXpl0it3r]

Check the documentation for sf:: Mouse::getPosition() it will show you an overload that takes the window.

[Hapax]

It's likely that you want the mouse position within the window rather than global location.
Basically, add the window as a parameter to the mouse's getPosition() thus:

sf::Mouse::getPosition(*window);

This position, though, should be converted to the co-ordinate system. This is not really necessary if your view matches the window exactly but there's no reason to not convert just in case.

Assuming you access your window using a pointer called window, try something like:

const sf::Vector2i mousePosition{ sf::Mouse::getPosition(*window); };
const sf::Vector2f mouseCoord{ window->mapPixelToCoords(mousePosition) };
player.setPosition(mouseCoord);

See the view tutorial, especially the point about co-ordinate conversion:
https://www.sfml-dev.org/tutorials/2.5/graphics-view.php#coordinates-conversions



@eXpl0it3r, sorry but I'd already typed this out so posted it anyway

[Blingu]

Thanks for your help, it can be closed and archived.