Compiler warnings on windows when compiling from source

[Rogal255]

Hi!
I got 5 warnings when I was compiling SFML from source on MSVC. I know that 3 of them are known (deprecated -backward compatibility) and already supressed them with compiler flags. But the remaining 2:

...\SFML\SFML\src\SFML\Graphics\Font.cpp(394): warning C4244: 'initializing': conversion from 'const int' to 'float', possible loss of data [...\SFML\SFML\build\src\SFML\Graphics\sfml-graphics.vcxproj]

...\SFML\SFML\src\SFML\Graphics\Font.cpp(395): warning C4244: 'initializing': conversion from 'const int' to 'float', possible loss of data [...\SFML\SFML\build\src\SFML\Graphics\sfml-graphics.vcxproj]

I've added explicit conversion from int to float (static_cast) in those lines and warnings are no longer presented. Is there any reason not to cast it explicitly? I saw same issues on SFML github repo during CI windows checks.

[eXpl0it3r]

We've started to clean up some of these warnings, but haven't fully gotten through them all and it's not merged yet. If the piece of copy expects a conversion, then it's not really an issue if it's implicitly converted, but it's generally shown as warning, because implicit conversions are quite an issue in C++, when you don't want it, but the compiler would just (silently) convert it.

Until this is fixed, the only workaround you can get is, to set the SFML headers as "system" headers, which won't trigger warnings.

[Rogal255]

Thanks, Shall I make a PR which will get rid of those warnings? - I have already silenced them on my SFML fork.

[eXpl0it3r]

I'm pretty sure, I've already fixed said warnings in this PR: https://github.com/SFML/SFML/pull/1791

[Rogal255]

Yep, fixed indeed Thanks